From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Aaron Ecay <aaronecay@gmail.com>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal
	function for general thread tagging
In-Reply-To: <m2wr8yeqe8.fsf@gmail.com>
References: <1325975294-646-1-git-send-email-jrollins@finestructure.net>
	<1325975294-646-2-git-send-email-jrollins@finestructure.net>
	<1325975294-646-3-git-send-email-jrollins@finestructure.net>
	<m239bpk7h0.fsf@gmail.com> <87boqdr3mz.fsf@servo.finestructure.net>
	<m2obudii3n.fsf@gmail.com> <87fwfnne02.fsf@servo.finestructure.net>
	<m2wr8yeqe8.fsf@gmail.com>
User-Agent: Notmuch/0.10.2+168~g34b8bac (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 10 Jan 2012 23:07:08 -0800
Message-ID: <87zkdun2eb.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, 11 Jan 2012 00:53:35 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> On Tue, 10 Jan 2012 18:56:29 -0800, Jameson Graef Rollins <jrollins@fines=
tructure.net> wrote:
> > Actually, the show-next argument was already part of the function.  I
> > did not introduce it.  And it wasn't optional originally, so if we want
> > to change that behavior we should probably do so in a separate patch.
>=20
> Hrm.  I didn=E2=80=99t communicate as clearly as I could have =E2=80=93 y=
ou are correct
> that the show-next argument to the notmuch-show-archive-internal function
> was pre-existing.  But notmuch-show-tag-thread-internal is a new function,
> with potentially expanded usefulness to third-party code.  Thus I think
> I=E2=80=99m in the clear to bikeshed about its calling convention.  :) It=
=E2=80=99s your
> patch, though, so it=E2=80=99s your call if you feel that the &optional g=
oes best
> in a new change.

No, I see your point, Aaron.  I'll rework it to make it a little clean
and more flexible when I resend.  Thanks again.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPDTUdAAoJEO00zqvie6q8IhAP/3kwvjMwTDoIMUw77eC6v8Wl
L0BFSvrqfwJvK4m0xesYnFRZCkcAbtdar0rQhx8Xnds5NmlqVqkX7K2xnY74YMNM
WYv+FzardQcX7Gyh4qv7ElZu5skmR6mDPiI/Gu54ctHYSWUuLAVrjQ3ShAyWtgO/
kEMbsT1aNzGd5k87RSu8vT0pU+m/w8/upXD2u9+Z0q6Zqs+1OY4y4MikAoCSsE0D
6VnPuGHGoAJm7eyDysIBt7dp4PatVGPc7Ody8qhj6F7NJKuFifgRtzJATF44Zvaq
BBgdj2eWPCl0kbd6VvT1Kk+6jkX0k1nTQuI3b7x1RKQvMwtIlkbP6JkhZwLlmHiI
0NM1+9wMxdIq9RjZQ4EKNdBk5AOlsEr7fLlzWzZ+ZU2AsrlnWSFyQbSZDNGkdmoR
ftBVUCx3ou7wEWjq/+PGRpQ0gHR9SD2D+yV1RELoF+a6sXNnF1CMvcnggyXbpwbu
QX40Faos8+e9jwndME+/AhbTLTxbPvTprye0G5zSJKLL9HkynunMZSdstBlouQPP
YLOaj0HCcOSbj8hg4B9AsRszWTeRoCgT5HGsctVzS35QF4TDuM3RhgbPU+DRKd81
n0hjiteU+i7YKtYDo6QKsd2Ye9n1ynEbWA3n9UfUCwghzIK2xeD0ZHI1tE6ZV17j
/4GtNDlZPlRBvFUAg5NM
=JMhb
-----END PGP SIGNATURE-----
--=-=-=--