From: Pieter Praet <pieter@praet.org>
To: Aaron Ecay <aaronecay@gmail.com>, David Edmondson <dme@dme.org>,
	Jameson Graef Rollins <jrollins@finestructure.net>
Subject: Re: [PATCH] v2 emacs: colorize buttonized 'id:' links depending on
	the target message's state
In-Reply-To: <m2sjjfb9xx.fsf@gmail.com>
References: <87hazva8qe.fsf@praet.org>
	<1326733053-25185-1-git-send-email-pieter@praet.org>
	<m2sjjfb9xx.fsf@gmail.com>
User-Agent: Notmuch/0.11+86~g67f4140 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 18 Jan 2012 11:08:54 +0100
Message-ID: <87aa5l8gqx.fsf@praet.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

On Mon, 16 Jan 2012 16:43:06 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> On Mon, 16 Jan 2012 17:57:33 +0100, Pieter Praet <pieter@praet.org> wrote:
> > * emacs/notmuch-show.el (notmuch-show-buttonized-link-colors):
> >   new defcustom, allows toggling colorization of buttonized links.
> >=20
> > * emacs/notmuch-show.el (notmuch-show-buttonized-link-present),
> > * emacs/notmuch-show.el (notmuch-show-buttonized-link-present-and-unrea=
d),
> > * emacs/notmuch-show.el (notmuch-show-buttonized-link-missing):
> >   new faces for buttonized id: links.
> >=20
> > * emacs/notmuch-show.el (notmuch-show-found-target-p): add optional arg
> >   VERIFY-UNREAD which causes results to be filtered by "tag:unread".
> >=20
> > * emacs/notmuch-show.el (notmuch-show-buttonize-links): use different
> >   face property depending on the result of `notmuch-show-found-target-p=
',
> >   causing buttons to available, available-and-unread and missing messag=
es
> >   to be displayed in a different color.
>=20
> I really like the idea behind this patch, but it has the very small
> problem that it colorizes too much.  So in reading this thread, there
> are things like =E2=80=9Cid:=E2=80=99s=E2=80=9D and =E2=80=9Cid:?=E2=80=
=9D that get colored the missing-message
> color (a very angry red, by default).  Though this isn=E2=80=99t likely t=
o be a
> very frequent problem with email messages that are not on this listserv
> :), it would be nice to fix it.  [...]

Excellent suggestion!

Amended patch follows.

> [...] Maybe you could change the regex that
> matches id:=E2=80=99s to require a little more structure =E2=80=93 an at-=
sign, perhaps.
> Or even requiring more than (say) 5 non-space characters after the
> message id would cut down sharply on the false positive rate.
>=20

Not sure how that would pan out.  It's fairly common behaviour to put
one or more spaces after a inline Message-Id, so I don't think such a
limitation would be warmly recepted.

> --=20
> Aaron Ecay


Peace

--=20
Pieter