Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B8A18431FBC for ; Tue, 24 Jan 2012 07:54:55 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ej4ivGJtE2bi for ; Tue, 24 Jan 2012 07:54:55 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 25F25431FB6 for ; Tue, 24 Jan 2012 07:54:55 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so3838797wgb.2 for ; Tue, 24 Jan 2012 07:54:53 -0800 (PST) Received: by 10.180.94.232 with SMTP id df8mr21497449wib.20.1327420493845; Tue, 24 Jan 2012 07:54:53 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id n3sm53654573wiz.9.2012.01.24.07.54.52 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Jan 2012 07:54:52 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 898269FD47; Tue, 24 Jan 2012 15:54:50 +0000 (GMT) To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH 3/4 v42] test: Add more helpers for emacs tests. In-Reply-To: <8762g1m7e9.fsf@gmail.com> References: <1326804748-8989-2-git-send-email-dme@dme.org> <1327341947-29206-1-git-send-email-dme@dme.org> <1327341947-29206-3-git-send-email-dme@dme.org> <8762g1m7e9.fsf@gmail.com> User-Agent: Notmuch/0.11+106~g382b2a0 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Tue, 24 Jan 2012 15:54:46 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Gm-Message-State: ALoCoQlr9HpnGH3HvAaMq9Mb+j8kpCzLkuYGL+IcZf9Ek2RpUF77I1AiRWxqMViKUBFMNa8yf12C X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2012 15:54:55 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 24 Jan 2012 19:45:18 +0400, Dmitry Kurochkin wrote: > 1. rename notmuch-test-compare to notmuch-test-expect-equal I'll change this. > 2. move the top level equal check to the non-list branch I'd rather not change this, though I'll write some commentary to explain how things are. > But both of these are subjective and minor, so I leave it to David to > decide whether to change or ignore them. Otherwise, the patch looks > good to me. >=20 > While replying to this email, I noticed a trailing whitespace. I may > have missed them in other patches. David, can you please check for > trailing white spaces and clean them? Yes. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8e1EYACgkQaezQq/BJZRY8cwCfc7uqdOR7rL5QU4k0YdKY1Vm1 dmoAnR3JpLEg6dPUYKw92tsHADv6mGFV =RQoS -----END PGP SIGNATURE----- --=-=-=--