From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: Don't move to the next thread unless the
	cursor is at the end of the buffer.
In-Reply-To: <cunaa54b7sz.fsf@hotblack-desiato.hh.sledj.net>
References: <1327996914-9644-1-git-send-email-dme@dme.org>
	<1327996914-9644-3-git-send-email-dme@dme.org>
	<87bopknvct.fsf@gmail.com>
	<cunaa54b7sz.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 31 Jan 2012 12:24:27 +0400
Message-ID: <877h08nutg.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 31 Jan 2012 08:22:20 +0000, David Edmondson <dme@dme.org> wrote:
> On Tue, 31 Jan 2012 12:12:50 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > On Tue, 31 Jan 2012 08:01:54 +0000, David Edmondson <dme@dme.org> wrote:
> > > When using the spacebar to scroll through a thread, hitting 'space'
> > > when the bottom of the last message is visible should take the cursor
> > > to the end of the buffer rather than immediately archiving the thread
> > > and moving to the next thread.
> > > ---
> > 
> > I did not notice this change yet, so +0
> > 
> > A style comment below.
> > 
> > >  emacs/notmuch-show.el |    5 +++++
> > >  1 files changed, 5 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > > index ec72ff8..3f54de0 100644
> > > --- a/emacs/notmuch-show.el
> > > +++ b/emacs/notmuch-show.el
> > > @@ -1319,6 +1319,11 @@ current window), advance to the next open message."
> > >        ;; This is not the last message - move to the next visible one.
> > >        (notmuch-show-next-open-message))
> > >  
> > > +     ((not (= (point) (point-max)))
> > > +      ;; This is the last message, but the cursor is not at the end of
> > > +      ;; the buffer. Move it there.
> > > +      (goto-char (point-max)))
> > 
> > Perhaps `unless' would be better here?
> 
> It's the CONDITION clause of `cond', so that wouldn't be appropriate.
> 

oh

This is why I like big diff contexts...

Regards,
  Dmitry

> > Regards,
> >   Dmitry
> > 
> > > +
> > >       (t
> > >        ;; This is the last message - change the return value
> > >        (setq ret t)))
> > > -- 
> > > 1.7.8.3
> > > 
> > > _______________________________________________
> > > notmuch mailing list
> > > notmuch@notmuchmail.org
> > > http://notmuchmail.org/mailman/listinfo/notmuch