From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/3] cli: mail-followup-to support
In-Reply-To: <cover.1364652420.git.jani@nikula.org>
References: <cover.1364652420.git.jani@nikula.org>
User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Sat, 11 May 2013 21:05:31 +0100
Message-ID: <87y5blcmes.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


Hi

On Sat, 30 Mar 2013, Jani Nikula <jani@nikula.org> wrote:
> This is v2 of [1], rebased against master and with a better commit
> message for patch 1/3. Patch 1/3 is trivial cleanup and IMO could just
> be merged. There was debate on the actual stuff 2/3 and 3/3 [2].
>
> I don't think adding a --reply-to=list option to notmuch reply is a good
> idea. We should just do the right thing and keep the cli simple. Perhaps
> we should drop the configuration (patch 2/3) altogether, and just
> support mail-followup-to?

I think I don't like it as a config option: I would prefer it either as
no option or a command line option (or the JSON as you suggest). I think
we currently honour reply-to unconditionally and ignore mail-reply-to:
is that correct? Otherwise I think the patch looks fine.

> Or, perhaps notmuch reply should return *all* options in json, and let
> the UI decide. Above all, let the UI change the reply style while
> editing the reply. I'd probably like this approach most, more than these
> patches, but I don't have the time to do it.

I have some preliminary patches to do this: will post shortly.

Best wishes

Mark


> Here are the patches anyway; perhaps they could be an intermediate step,
> or just a reference for anyone willing to do the above.
>
>
> BR,
> Jani.
>
>
> [1] id:5eaa3acc22ee5513bdce5ab931b7a79ade880e06.1362254104.git.jani@nikula.org
> [2] id:20130303120745.GA4884@hili.localdomain
>
> Jani Nikula (3):
>   cli: config: remove unnecessary braces from if blocks
>   cli: add reply.honor_followup_to configuration option
>   cli: support Mail-Followup-To: in notmuch reply
>
>  notmuch-client.h |    7 +++++++
>  notmuch-config.c |   56 ++++++++++++++++++++++++++++++++++++++++++------------
>  notmuch-reply.c  |   25 ++++++++++++++++++++++--
>  3 files changed, 74 insertions(+), 14 deletions(-)
>
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch