DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:content-type;
	b=iw7YVPGbugyvRoasCoz6PuElJdV5rIPsi7Ze/EihZFZf+i1FM269ddXF/gVeJYwxrw
	dm2cwwRHNfCyuTVvdJ6BkQBVrDD6AkUDjmvmi1sNIdYbbLvfnKY9z4CLqdyX5Z2sLjCU
	bjrElVsGQBKahIAjOy/S59K6yztoijrIspJyY=
MIME-Version: 1.0
In-Reply-To: <87ljdbh61t.fsf@steelpick.2x.cz>
References: <330356ae1003282354s639a0ff5p34a6a29bbe145ed5@mail.gmail.com>
	<87ljdbh61t.fsf@steelpick.2x.cz>
Date: Mon, 29 Mar 2010 09:43:31 -0700
Message-ID: <330356ae1003290943v19cfcabeveff2cdfd46df5601@mail.gmail.com>
From: Bhaskara Marthi <bhaskara@gmail.com>
To: notmuch@notmuchmail.org
Content-Type: multipart/alternative; boundary=005045013bff9db1610482f336b9
Subject: Re: [notmuch] [PATCH] Fix compilation when getline is not available
Precedence: list

--005045013bff9db1610482f336b9
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Mar 29, 2010 at 1:43 AM, Michal Sojka <sojkam1@fel.cvut.cz> wrote:

> On Mon, 29 Mar 2010, Bhaskara Marthi wrote:
> > Hi all, I'm trying to build notmuch on os x (master branch from today).
>  I
> > got the ports for gmime and xapian, and installed talloc from source,
> with
> > some minor hitches (just getting talloc alone from samba failed on
> autoconf
> > due to lack of libreplace.m4, so I installed all of samba from a port; a
> > pkg-config file for talloc was not put in the right place after that,
> > though, so I had to make one).
> >
> > Anyway, now compilation runs into the following error.  Looks like an
> issue
> > with the makefile given that getline is in fact defined in compat/.  How
> > should I fix this?
>
> The following patch should fix it.
>

Works for me.  Thanks!
- Bhaskara



> ---
>  Makefile              |    2 +-
>  compat/Makefile.local |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 46f001c..93c6b2b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -46,7 +46,7 @@ subdirs = compat emacs lib
>  global_deps = Makefile Makefile.config Makefile.local \
>        $(subdirs:%=%/Makefile) $(subdirs:%=%/Makefile.local)
>
> -include Makefile.config Makefile.local $(subdirs:%=%/Makefile.local)
> +include Makefile.config $(subdirs:%=%/Makefile.local) Makefile.local
>
>  # The user has not set any verbosity, default to quiet mode and inform the
>  # user how to enable verbose compiles.
> diff --git a/compat/Makefile.local b/compat/Makefile.local
> index 17b4514..9f84c5f 100644
> --- a/compat/Makefile.local
> +++ b/compat/Makefile.local
> @@ -1,7 +1,7 @@
>  dir := compat
>  extra_cflags += -I$(dir)
>
> -notmuch_compat_srcs =
> +notmuch_compat_srcs :=
>
>  ifneq ($(HAVE_GETLINE),1)
>  notmuch_compat_srcs += $(dir)/getline.c $(dir)/getdelim.c
> --
> 1.7.0.2
>

--005045013bff9db1610482f336b9
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Mon, Mar 29, 2010 at 1:43 AM, Michal =
Sojka <span dir=3D"ltr">&lt;<a href=3D"mailto:sojkam1@fel.cvut.cz">sojkam1@=
fel.cvut.cz</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" styl=
e=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; =
padding-left: 1ex;">
On Mon, 29 Mar 2010, Bhaskara Marthi wrote:<br>
&gt; Hi all, I&#39;m trying to build notmuch on os x (master branch from to=
day). =A0I<br>
&gt; got the ports for gmime and xapian, and installed talloc from source, =
with<br>
&gt; some minor hitches (just getting talloc alone from samba failed on aut=
oconf<br>
&gt; due to lack of libreplace.m4, so I installed all of samba from a port;=
 a<br>
&gt; pkg-config file for talloc was not put in the right place after that,<=
br>
&gt; though, so I had to make one).<br>
&gt;<br>
&gt; Anyway, now compilation runs into the following error. =A0Looks like a=
n issue<br>
&gt; with the makefile given that getline is in fact defined in compat/. =
=A0How<br>
&gt; should I fix this?<br>
<br>
The following patch should fix it.<br></blockquote><div><br>Works for me.=
=A0 Thanks!<br>- Bhaskara<br><br>=A0</div><blockquote class=3D"gmail_quote"=
 style=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.=
8ex; padding-left: 1ex;">

---<br>
=A0Makefile =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A02 +-<br>
=A0compat/Makefile.local | =A0 =A02 +-<br>
=A02 files changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/Makefile b/Makefile<br>
index 46f001c..93c6b2b 100644<br>
--- a/Makefile<br>
+++ b/Makefile<br>
@@ -46,7 +46,7 @@ subdirs =3D compat emacs lib<br>
=A0global_deps =3D Makefile Makefile.config Makefile.local \<br>
 =A0 =A0 =A0 =A0$(subdirs:%=3D%/Makefile) $(subdirs:%=3D%/Makefile.local)<b=
r>
<br>
-include Makefile.config Makefile.local $(subdirs:%=3D%/Makefile.local)<br>
+include Makefile.config $(subdirs:%=3D%/Makefile.local) Makefile.local<br>
<br>
=A0# The user has not set any verbosity, default to quiet mode and inform t=
he<br>
=A0# user how to enable verbose compiles.<br>
diff --git a/compat/Makefile.local b/compat/Makefile.local<br>
index 17b4514..9f84c5f 100644<br>
--- a/compat/Makefile.local<br>
+++ b/compat/Makefile.local<br>
@@ -1,7 +1,7 @@<br>
=A0dir :=3D compat<br>
=A0extra_cflags +=3D -I$(dir)<br>
<br>
-notmuch_compat_srcs =3D<br>
+notmuch_compat_srcs :=3D<br>
<br>
=A0ifneq ($(HAVE_GETLINE),1)<br>
=A0notmuch_compat_srcs +=3D $(dir)/getline.c $(dir)/getdelim.c<br>
<font color=3D"#888888">--<br>
1.7.0.2<br>
</font></blockquote></div><br>

--005045013bff9db1610482f336b9--