Date: Sat, 3 Jan 2015 08:45:06 -0800
From: "W. Trevor King" <wking@tremily.us>
To: David Bremner <david@tethera.net>
Subject: Re: [PATCH] doc: Allow rst2man.py as an alternative to rst2man
Message-ID: <20150103164506.GR14967@odin.tremily.us>
References: <1420294479-27224-1-git-send-email-tomi.ollila@iki.fi>
	<1420300167-5060-1-git-send-email-david@tethera.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="OIgbTO1BpLp4mLc1"
Content-Disposition: inline
In-Reply-To: <1420300167-5060-1-git-send-email-david@tethera.net>
OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;
	url=http://tremily.us/pubkey.txt
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: notmuch@notmuchmail.org
Precedence: list


--OIgbTO1BpLp4mLc1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 03, 2015 at 04:49:27PM +0100, David Bremner wrote:
> At the risk of bike-shedding, rewrite the configure check to be more
> "obvious". This is pretty subjective, but in particular I'm not a
> big fan of resetting RST2MAN at the bottom of every iteration of the
> for loop.  Also conform a bit more to the convention of using a
> lower case variable in configure and assigning it in Makefile.

I'm fine with all of these changes.

> @@ -854,6 +860,9 @@ HAVE_RST2MAN=3D${have_rst2man}
>  # Whether there's a doxygen binary available for building api documentat=
ion
>  HAVE_DOXYGEN=3D${have_doxygen}
> =20
> +# The path to the rst2man program for building documentation.
> +RST2MAN =3D ${rst2man}
> +
>  # The directory to which desktop files should be installed
>  desktop_dir =3D \$(prefix)/share/applications
> =20

I'd keep the RST2MAN entry right after HAVE_RST2MAN, instead of having
HAVE_DOXYGEN between them.

Cheers,
Trevor

--=20
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

--OIgbTO1BpLp4mLc1
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUqByRAAoJEG8/JgBt8ol8AhEQAJg1GcrqLh+A3vJRc18qseNC
alJFh181Yn9CeUoeeUOcACBbGYftQqWgTynaqW+o82pzekWrUrTGgIWSx0Y/exM+
SHpdqesGUgE+9fBqY3sViCpToIxqdPy/D5rYJNZ7vRnSt6oWmPay+lWAR0t0mzfE
1LkAsv3BXTcwvScQIsIyepQiLH4srSFqneizzIEojApYSW8CMlarMpQzbkegPSOd
1WsSnKnE9i5tCn4IQv0Q4JUleMU1NEFfIhlac74J1h4jlRpCk2sGRepkJEq89hK0
DFOdPRIxrX5kwfnmn9u25gDFe0l+pU2frVN7N169+nSRdnd0l/1w3uUbch8JjDgk
JxRXt/yQO+I4HxjNTmQwCjrB0YyvUPzwoPXqsBA3r9oc+fzPtDUR2PcSH8w5zk7V
FBnZ3Y9Fu4td6yLCN5Oi0HL1frf0R6VwmYD/OO9PRgKRjAfyEddtK9MmBB2m9DrB
xhSRtWa6xFbti19bV79yMFHzTvphbCXKrAy7R6d8GkLhjyI0mERGiqu/G61HND8M
WdMf+2HuWR4J/jbVrcItsm0HDU4HLPb4Gt1C2wIk2twt06f+GyB2ti2i5fNi24tE
uZwwRrOFExAggIihgjcTCX8d+ntgtyxaEh+A1rhCPoueOv33VF6FQwdZhsNLj7/t
T2ommQgjCDXeKlX3t2yH
=8DBd
-----END PGP SIGNATURE-----

--OIgbTO1BpLp4mLc1--