Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 196F8431FD0 for ; Fri, 15 Jul 2011 08:58:54 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ELV8nkMnY4V9 for ; Fri, 15 Jul 2011 08:58:52 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 3951C431FB6 for ; Fri, 15 Jul 2011 08:58:52 -0700 (PDT) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 9749C66E0212; Fri, 15 Jul 2011 08:58:51 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from servo.finestructure.net (cpe-98-149-172-122.socal.res.rr.com [98.149.172.122]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 67BAB66E0207; Fri, 15 Jul 2011 08:58:48 -0700 (PDT) Received: by servo.finestructure.net (Postfix, from userid 1000) id 5FC1A7C9; Fri, 15 Jul 2011 08:58:48 -0700 (PDT) From: Jameson Graef Rollins To: Patrick Totzke , notmuch@notmuchmail.org Subject: Re: date_relative in notmuch-search In-Reply-To: <20110714222258.GA11914@brick.lan> References: <20110714222258.GA11914@brick.lan> User-Agent: Notmuch/0.5-353-gb44d56e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 15 Jul 2011 08:58:45 -0700 Message-ID: <87oc0v4jt6.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2011 15:58:54 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 14 Jul 2011 23:22:58 +0100, Patrick Totzke wrote: > I wodered why "notmuch search --format=3Djson" doesn't provide the "date_= relative" field for > results, as the show command does. >=20 > I'm not expert on notmuch internals but I got it working like this: Hi, Patrick. I think this is a very reasonable patch. However, there are a couple of things you need to do to get this patch accepted. First of all, you should send the patch to the list in a format that will allow it to be applied directly to a git repo. In particular, it needs to include a good commit log message. Look at using git send-mail to send it to the list, which will format it correctly. Also, I'm quite sure this patch will require a couple of changes to the test suite. You should submit a patch that changes the test suite to reflect the desired changes *first*, followed by the patch that fixes the issue. Thanks! jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOIGO2AAoJEO00zqvie6q8ORkP/RBb/+gWm40DAq29Y538DAOe 5/BMnUP+zuNuMYUDjRWIrxVvgNjXGpXQpRBdueuxhEMPKiCNC48nioIncsNJo1k8 RHwVk9iPlZXd8mtFxvfOzQoWp4UNjZ7B6n53xfvsHH8GrTUS/ld1hmGxetrsF7Qr Ri8xQZtSq3WpPDj6kj+xfw9hSkQIZHK+ncHldBhw7gh1oJfL1WM7D8dzueqd1SVg V+EvB7F/2F/oolUz1fx7OhDpyp7KQyf2V8OMQc3LzFBLrOow7XJFxM6J1ruqdlP0 da9YxvVfjxiuVSdaOfwzm5PYkN6lY+bOHRsP5U4hE8p2NQkDpzFwLIjkWfLcs5zR qpllCQeySk/YxpxhS5MHQwbhklkvF8XhQDfrlCWGMcf+7pouvhC/yvOAXIS3rO+n j35UXqs/BJ1W/qLlO1C2BkR1zLRcJSYg3aYZNchuXKt2eWVRBpCL/qM8lqYutsWo MeLZ6kwDjM9tNNBavTllJGEaUDI9RfUCa3UHIDRfD5EQQe+s3IiR4kP97DS8qK+p FKzLmFptZOthuwKp/LeFXJPn8XxcMYculpXm4ffBZ74H0V+2y4ZUZeVPraFN3fBS 0EvPGSFJIvAATKek1A71sI1nNjjpiAEiF+f/WW1Y5Rx89HWrdwu9moMUxWTafkAc XpySAAOiNX3vF6sNcKJk =rkTD -----END PGP SIGNATURE----- --=-=-=--