Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 36035431FD0 for ; Wed, 2 Nov 2011 07:18:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id czwZkQ+xIrjr for ; Wed, 2 Nov 2011 07:18:21 -0700 (PDT) Received: from mail-vw0-f53.google.com (mail-vw0-f53.google.com [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A24DF431FB6 for ; Wed, 2 Nov 2011 07:18:21 -0700 (PDT) Received: by vws19 with SMTP id 19so188375vws.26 for ; Wed, 02 Nov 2011 07:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=bqhj1qczT0gvsudUKl5lDUJLXbxYoQotn731SUpxcoE=; b=xO2txU/iQBj0RITqB3e1LTFAEOemSpS+uw50PULBm52RlUUYg6zg5F6KC3zwXuCj4Q Cs+Z48Mekfx2HGvZFq3Sh4mFvazfuPDHEq8H/75TrLgCoWks3rvFcpyYXb2Dcry0b1Io qYsePbi2m27zwD2sTf+OPG3EbGrHbCUyITGfE= MIME-Version: 1.0 Received: by 10.68.30.198 with SMTP id u6mr5134367pbh.38.1320243500617; Wed, 02 Nov 2011 07:18:20 -0700 (PDT) Sender: amdragon@gmail.com Received: by 10.143.166.17 with HTTP; Wed, 2 Nov 2011 07:18:20 -0700 (PDT) In-Reply-To: <1319813790-17418-1-git-send-email-david@tethera.net> References: <1319813790-17418-1-git-send-email-david@tethera.net> Date: Wed, 2 Nov 2011 10:18:20 -0400 X-Google-Sender-Auth: lVFrHpcRzRIDFGqBeFukRUbSvj0 Message-ID: Subject: Re: [PATCH] lib/database.cc: use flush Xapian method instead of commit From: Austin Clements To: David Bremner Content-Type: text/plain; charset=ISO-8859-1 Cc: notmuch@notmuchmail.org, David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2011 14:18:22 -0000 On Fri, Oct 28, 2011 at 10:56 AM, David Bremner wrote: > From: David Bremner > > Apparently the method was renamed in Xapian 1.1.0 but the old method > name will stay around for a while. It seems better to stick with the > old name to make notmuch compile with older versions of Xapian, at > least for now. LGTM