Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 719DB431FB6 for ; Sun, 27 Mar 2011 19:57:50 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.698 X-Spam-Level: X-Spam-Status: No, score=-0.698 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HAmEQrMfE9xo for ; Sun, 27 Mar 2011 19:57:49 -0700 (PDT) Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 9E6D1431FB5 for ; Sun, 27 Mar 2011 19:57:49 -0700 (PDT) Received: by qwb7 with SMTP id 7so1491505qwb.26 for ; Sun, 27 Mar 2011 19:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:date:x-google-sender-auth :message-id:subject:from:to:cc:content-type; bh=trz0q/y3Pt8s5ghJgnEoe2iIBPxiWDRzJ3tipztJDZU=; b=u63Bzg5xeGFzRM5C6VcLUlEQwv4D6pFUEM7ZdE1yS1zdcmecLmhNwDtvE6hRIsV3XD jihzjb5TnY/fSb3u3RXc3ZBfsCqObbdavsdjt6bp+KOuHWmxYemHMt8ITXjPeOssegg1 WoU8RmXAWlk/PVTGbWwnD0g2gJJM4IyEww5OE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; b=oyr14ZsifM78Ow1zuzMXsVC71SGRdbk072yZKjqBZJbEPnKz+B7RI23ie5w+rsl8s0 OIRWx108/9NoVnkO3WhwNbGCMT+6fI5N1aPuKl7gwEKiXGb/P6w5sAHOVDQpY8FnDngG ZsPckb0o0LKCJwYa+VlpV5mRLjma1XvRzVPV0= MIME-Version: 1.0 Received: by 10.229.130.168 with SMTP id t40mr2827290qcs.140.1301281066382; Sun, 27 Mar 2011 19:57:46 -0700 (PDT) Sender: amdragon@gmail.com Received: by 10.229.30.68 with HTTP; Sun, 27 Mar 2011 19:57:46 -0700 (PDT) Received: by 10.229.30.68 with HTTP; Sun, 27 Mar 2011 19:57:46 -0700 (PDT) Date: Sun, 27 Mar 2011 22:57:46 -0400 X-Google-Sender-Auth: cJ-qm_g9zLYg_nas2MCF0nF8G54 Message-ID: Subject: Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces From: Austin Clements To: Jameson Rollins Content-Type: multipart/alternative; boundary=0015175925fab6f465049f821bcb Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2011 02:57:50 -0000 --0015175925fab6f465049f821bcb Content-Type: text/plain; charset=ISO-8859-1 On Sun, Mar 27, 2011 at 1:26 AM, Jameson Rollins wrote: > On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins < jrollins@finestructure.net> wrote: >> This enables the proper face customization UI for >> notmuch-search-line-faces. > > Hey, folks. amdragon was the one who figured out that custom-face-edit > was the correct value-type to use to get the face customization ui for > the notmuch-search-line-faces list. However, he seems to think this > might not be the right solution. Austin: care to comment? My concern is that it's unclear if the custom-face-edit widget is considered a public interface, or if it's internal to customize and thus could change at any time. These things are always a bit murky in Emacs. custom-face-edit has been around for a few major versions, though it only recently (somewhere between Emacs 22 and 23) became embeddable in a customize widget like this. We should just ask on an Emacs mailing list if this is okay, or if it will break catastrophically and without warning at some point (or if there's a more official solution). --0015175925fab6f465049f821bcb Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Sun, Mar 27, 2011 at 1:26 AM, Jameson Rollins <jrollins@finestructure.net> wrote:
> On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins <jrollins@finestructure.net> w= rote:
>> This enables the proper face customization UI for
>> notmuch-search-line-faces.
>
> Hey, folks. =A0amdragon was the one who figured out that custom-face-e= dit
> was the correct value-type to use to get the face customization ui for=
> the notmuch-search-line-faces list. =A0However, he seems to think this=
> might not be the right solution. =A0Austin: care to comment?

My concern is that it's unclear if the custom-face-edit widget is co= nsidered a public interface, or if it's internal to customize and thus = could change at any time. These things are always a bit murky in Emacs. cus= tom-face-edit has been around for a few major versions, though it only rece= ntly (somewhere between Emacs 22 and 23) became embeddable in a customize w= idget like this. We should just ask on an Emacs mailing list if this is oka= y, or if it will break catastrophically and without warning at some point (= or if there's a more official solution).

--0015175925fab6f465049f821bcb--