From: David Bremner <david@tethera.net>
To: "Alexey I. Froloff" <raorn@raorn.name>
Subject: Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax
In-Reply-To: <20130430095213.GA2861@raorn.name>
References: <20130409083010.GA27675@raorn.name>
	<1365549369-12776-1-git-send-email-raorn@raorn.name>
	<87vc74vn2n.fsf@zancas.localnet> <20130430095213.GA2861@raorn.name>
User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Fri, 03 May 2013 21:54:29 -0300
Message-ID: <871u9nva2i.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 04 May 2013 00:54:46 -0000

"Alexey I. Froloff" <raorn@raorn.name> writes:

>
>> > +    void *local = talloc_new (message);
>>       we should handle ENOMEM here, I think.
> There are 16 talloc_new() calls and ENOMEM is not handled
> anywhere.

This makes me a bit sad but I agree it's not your fault ;).
>
>> > +    /* _notmuch_message_add_term() may return
>> > +     * NOTMUCH_PRIVATE_STATUS_TERM_TOO_LONG here.  We can't fix it, but
>> > +     * this is not a reason to exit with error... */
>> > +    if (_notmuch_message_add_term (message, "list", list_id))
>> > +	fprintf (stderr, "Warning: Not indexing List-Id: <%s>\n", list_id);
>> This should say why the indexing failed.
> There should be strerror-like function, then can give description
> for a given status code.

There is, but only for the public status values. 

I guess the most correct thing would be to check for equality with
NOTMUCH_PRIVATE_STATUS_TERM_TOO_LONG, print an appropriate error message
if so, and otherwise use
notmuch_status_to_string(COERCE_STATUS(private_status))

d