Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 59D0A431FC3 for ; Thu, 2 Feb 2012 06:34:42 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6l9AaQZNRjcY for ; Thu, 2 Feb 2012 06:34:41 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 20779421176 for ; Thu, 2 Feb 2012 06:34:06 -0800 (PST) Received: by wibhi8 with SMTP id hi8so1957706wib.26 for ; Thu, 02 Feb 2012 06:34:04 -0800 (PST) Received: by 10.181.13.113 with SMTP id ex17mr4968088wid.15.1328193244760; Thu, 02 Feb 2012 06:34:04 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id ex2sm7757361wib.1.2012.02.02.06.34.02 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Feb 2012 06:34:03 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 57C2EA0474; Thu, 2 Feb 2012 14:34:01 +0000 (GMT) To: Jameson Graef Rollins , Dmitry Kurochkin , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible In-Reply-To: <87ehuetqjz.fsf@servo.finestructure.net> References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com> <87r4yfszx9.fsf@servo.finestructure.net> <87pqdync64.fsf@gmail.com> <87k446n8ji.fsf@gmail.com> <87ehuetqjz.fsf@servo.finestructure.net> User-Agent: Notmuch/0.11+143~g3619628 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Thu, 02 Feb 2012 14:33:56 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2012 14:34:42 -0000 --=-=-= Content-Type: text/plain On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins wrote: > If this is really a problem, I vote for 1. In general, I am not in > favor of making the test suite more complicated than it needs to be. After listening to the debate, I agree. The documentation should state that the order is 'expected actual' (or the other way around) and offenders should be shot on sight^W^W^Wfixed. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8qntQACgkQaezQq/BJZRbNXgCdEWzhp+vJP6WIrzWqSaFDb5ZN S2IAnjuQpSmXMJw8/IxCBJ9j9FjQViaC =sjXF -----END PGP SIGNATURE----- --=-=-=--