DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:cc:subject
	:in-reply-to:references:date:message-id:mime-version:
	content-type; q=dns; s=sspaeth.de; b=flVEbuy11SPZs76/MlgZ/brIf4e
	UjI6F3fj24hbnVp9YlrJr/Qs0iPkeRpnGndDQckR9TFBW2r7Z7WvKze1CE7cBHdv
	I6jcYboBTC7fEhcnN3Ss6R5li73vlnKG0EiN6v0F5WEVuA7G5J2Yt+dAA6tCK3OA
	/xy/8FuL1YGEz0jA=
From: Sebastian Spaeth <Sebastian@SSpaeth.de>
To: Brian May <brian@microcomaustralia.com.au>,
	Patrick Totzke <patricktotzke@googlemail.com>
Subject: Re: [python] get all messages of a thread
In-Reply-To: <BANLkTikEJ9dJ5kLg2QJQ+egHg2sh7S1wiA@mail.gmail.com>
References: <1306588052-sup-9838@brick>
	<BANLkTikEJ9dJ5kLg2QJQ+egHg2sh7S1wiA@mail.gmail.com>
User-Agent: Notmuch/0.5-209-gc8b5718 (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Thu, 02 Jun 2011 09:05:29 +0200
Message-ID: <87aae07lxi.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch <notmuch@notmuchmail.org>
Precedence: list

--=-=-=

On Wed, 1 Jun 2011 15:35:35 +1000, Brian May wrote:
> Oh, I see, for your code, there is a implied call to __len__, and the
> __len__ function is completely broken for the reasons described in the
> documentation:

It seems to have been a bad idea to implement __len__ at all for the
Messsages() construct in the python bindings, and I wonder if I should
remove it.

On the other hand, it seems that list(Messages()) implicitely calls
len(), or so it seems from the error that we get when trying to list() a
messages object.

An alternative is to implement len() as a call to count_messages() which
has for me so far always returned the correct number of messages without
using up the iterator. However, the xapian docs explicitely state that
it does not guarantee that the count will be correct, so len() might
return a wrong message size (potentially).

What would be the best way to solve this (besides fixing the C api to
allow to reset the iterator ;-) ?)

I could implement a custom .as_list() function that returns the
Messages() object as a list that is guaranteed to be stable, by copying
out the Message() objects into a list.

Sebastian

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk3nNjkACgkQVYX1jMgnoGJwrwCfTDJ4FxGbMYRyI8rcWrHvOHTz
lDsAnR1MA0rfwKMBBJzAVLJ73jZpbInt
=98j3
-----END PGP SIGNATURE-----
--=-=-=--