From: Carl Worth <cworth@cworth.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] Add part filename and content-id in notmuch show
	output if available.
In-Reply-To: <1306620228-24351-1-git-send-email-dmitry.kurochkin@gmail.com>
References: <1306620228-24351-1-git-send-email-dmitry.kurochkin@gmail.com>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Tue, 28 Jun 2011 20:14:08 -0700
Message-ID: <87iprp72in.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Sun, 29 May 2011 02:03:47 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> Also, the patch adds Content-id to text output format of notmuch
> show.

I don't think I've raised this point before, but I've been tempted to
setup a git hook that rejects any commits with a paragraph beginning
with the word "also" or the word "additionally". These words are clues
to me that the commit is doing multiple independent things and should
really be split up.

> The patch makes notmuch show always output filename if available,
> independent of Content-Disposition.  Both JSON and text output
> formats are changed.

The commit message claims to change both JSON and text output, (and the
patch bears that out). But the test suite only gets changes to text
output.

This suggests to me that the test suite needs an additional test here
(for a "Content-Disposition: inline" attachment with a filename).

What can I say, I must be feeling soft today, because in spite of both
of those issues I've just pushed these two commits, (I did augment the
commit message of the second commit to be more than a single line=E2=80=94I=
 know
that I've discussed that issue before).

Thanks, Dmitry, for the improvements.

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4KmIAACgkQ6JDdNq8qSWjm0gCfdxQ/xyL3eA1eMhHDLooglEha
x1IAniiWNWvrNUy1R5nh9G5G6hpP0lWE
=fW5D
-----END PGP SIGNATURE-----
--=-=-=--