From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Michal Sojka <sojka@os.inf.tu-dresden.de>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Fix display of highlighted line in
	notmuch-search
In-Reply-To: <87ehtvheig.fsf@steelpick.2x.cz>
References: <87mx8lpd5o.fsf@nikula.org>
	<1329239387-6300-1-git-send-email-sojka@os.inf.tu-dresden.de>
	<87wr7ngand.fsf@gmail.com> <87ehtvheig.fsf@steelpick.2x.cz>
User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 16 Feb 2012 03:25:59 +0400
Message-ID: <87ty2rfzlk.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 16 Feb 2012 00:18:31 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:
> On Wed, 15 Feb 2012, Dmitry Kurochkin wrote:
> > Hi Michal.
> > 
> > On Tue, 14 Feb 2012 18:09:47 +0100, Michal Sojka <sojka@os.inf.tu-dresden.de> wrote:
> > > When notmuch-search-line-faces is used to set background color in search
> > > results, the highlight of the current line is not always displayed
> > > correctly. This patch fixes that by increasing the priority property of
> > > the highlight overlay.
> > > ---
> > 
> > How about changing `notmuch-search-color-line' to use text properties
> > instead of overlays?  Then hl-line overlay would take priority over it
> > without these changes.
> > 
> > See [1] by David Edmondson on why text properties are better in
> > general.  I plan to use text properties here to simplify updating the
> > face when tags are changed.
> 
> Hmm, I always wondered why notmuch uses overlays even if Elisp manual
> says they don't scale. I remember that I wanted to replace that long
> time ago, but there was some problem, which I forgot. Maybe it was the
> invisibility David mentions. I guess there is some invisible text in
> search output, isn't it?
> 

Yes.  Also other faces (e.g. date, subject) are used in search.  If we
used properties in `notmuch-search-color-line', we would have to merge
with other properties.  So I take my proposal back.

Regards,
  Dmitry

> -Michal