DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:subject:in-reply-to:references:user-agent:date
	:message-id:mime-version:content-type:content-transfer-encoding;
	b=I2lzRmojbfogxGrVxY4MgESyLN7y+vo/yTNYlNKSxv0lILClvwc7j+W6A3Xt605oZo
	vrP1OKkmF6Bk1l5tXKLFYYR60/ISdhfFkf0GnZYqnLtVQlOjvsGJL0rGgLrGR8xBltfB
	5JSQy+BnnI22o2qKzo3X/gzO0hpsNEFDk2j+g=
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Austin Clements <amdragon@mit.edu>
Subject: Re: [PATCH] Save and restore point explicitly in
	`notmuch-wash-toggle-invisible-action'.
In-Reply-To: <BANLkTi=_PszwPDRbRxVpVhkT=YRAi5dGDQ@mail.gmail.com>
References: <1306090675-26982-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1306164587-20326-1-git-send-email-dmitry.kurochkin@gmail.com>
	<87oc2rlujb.fsf@yoom.home.cworth.org> <8762ozrfrr.fsf@gmail.com>
	<87oc2rvjvj.fsf@yoom.home.cworth.org> <871uznrbh5.fsf@gmail.com>
	<BANLkTi=_PszwPDRbRxVpVhkT=YRAi5dGDQ@mail.gmail.com>
User-Agent: Notmuch/0.5-216-g0104e23 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 25 May 2011 03:00:43 +0400
Message-ID: <87y61vpuuc.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

On Tue, 24 May 2011 18:43:41 -0400, Austin Clements <amdragon@mit.edu> wrot=
e:
> On Tue, May 24, 2011 at 6:16 PM, Dmitry Kurochkin
> <dmitry.kurochkin@gmail.com> wrote:
> > When a user clicks the button, the cursor is somewhere inside the old
> > label. =C2=A0If we save the point as a marker, after step 3 it would en=
d up
> > at the position where the old label was. =C2=A0If the new label is inse=
rted
> > before the old one, that means after the new label. =C2=A0So the cursor=
 jumps
> > from inside the button to the position after the button. =C2=A0Since th=
e new
> > button is placed at the same position where the old one was, restoring
> > the point to the same offset it was at the beginning works as we need.
>=20
> Saving point this way is a bit dangerous, though.  For example, if
> you're near the end of the buffer and shorten the label, attempting to
> restore the point could result in an error (or, a more benign example:
> the cursor could wind up outside the label so pressing RET repeatedly
> won't toggle it).
>=20
> Unfortunately, I don't know of a clean solution to this, but I think I
> would rather the cursor move, but stay within the label (probably
> moving to the beginning), than have problems like the above.

Good point.  I will send an amended patch that moved to min(old-pos,
new-button-end - 1).  This leaves the cursor in place when possible and
avoids problems with out-of-bounds position (assuming the label is not
empty).

Regards,
  Dmitry