Date: Thu, 2 May 2013 15:45:30 +0200
From: Vladimir Marek <Vladimir.Marek@Oracle.COM>
To: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH 01/24] lib/message.cc: stale pointer bug
Message-ID: <20130502134530.GB23259@pub.cz.oracle.com>
Mail-Followup-To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org,
	Vladimir Marek <vlmarek@volny.cz>
References: <1367444021-2757-1-git-send-email-Vladimir.Marek@oracle.com>
	<m2sj25snsk.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <m2sj25snsk.fsf@guru.guru-group.fi>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org, Vladimir Marek <vlmarek@volny.cz>
Precedence: list

> >      int prefix_len = strlen (prefix);
> > -    const char *term = NULL;
> > +    std::string term;
> >      char *value;
> >  
> >      i.skip_to (prefix);
> >  
> > -    if (i != end)
> > -	term = (*i).c_str ();
> > +    if (i == end)
> > +	return NULL;
> >  
> > -    if (!term || strncmp (term, prefix, prefix_len))
> > +    term = *i;
> 
> ... hmm, a raii(?) solution above would be std::string term = *i;

I'm not sure what's raii (I'm not very good at c++ ...), but I guess you
mean to use 'std::string term = *i;' to avoid copy constructor. That
surely is a good idea. Let me rework the patch!

-- 
	Vlad