From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Thomas Jost <schnouki@schnouki.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'
In-Reply-To: <87ipl9k33a.fsf@schnouki.net>
References: <1324491506-1134-1-git-send-email-dmitry.kurochkin@gmail.com>
	<1324491506-1134-2-git-send-email-dmitry.kurochkin@gmail.com>
	<87ipl9k33a.fsf@schnouki.net>
User-Agent: Notmuch/0.10.2+116~ga89e197 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 22 Dec 2011 01:54:21 +0400
Message-ID: <87d3bh7fqq.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Wed, 21 Dec 2011 22:49:13 +0100, Thomas Jost <schnouki@schnouki.net> wrote:
> On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Test that `notmuch-hello-refresh-hook' is called once when
> > `notmuch-hello' is called and twice when calling
> > `notmuch-hello-update' after that.
> > 
> > The tests are very similar to tests for `notmuch-hello-mode-hook'.
> 
> Quite nice, better than what I sent earlier [1] :)
> 
> However I'm not sure that notmuch-hello.el is the right place for this
> kind of stuff; notmuch-lib.el may be better (so that it can also be used
> in other hooks.
> 

These patches do not touch notmuch-hello.el.  The functions are added to
test/test-lib.el.

Regards,
  Dmitry

> Regards,
> Thomas
> 
> [1] id:"1324473189-8622-1-git-send-email-schnouki@schnouki.net"
> 
> 
> > ---
> >  test/emacs       |   19 +++++++++++++++++++
> >  test/test-lib.el |    1 +
> >  2 files changed, 20 insertions(+), 0 deletions(-)
> > 
> > diff --git a/test/emacs b/test/emacs
> > index dffad0f..ca82445 100755
> > --- a/test/emacs
> > +++ b/test/emacs
> > @@ -495,4 +495,23 @@ counter=$(test_emacs \
> >  )
> >  test_expect_equal "$counter" 1
> >  
> > +test_begin_subtest "notmuch-hello-refresh hook is called"
> > +counter=$(test_emacs \
> > +    '(let ((notmuch-hello-refresh-hook-counter 0))
> > +       (kill-buffer "*notmuch-hello*")
> > +       (notmuch-hello)
> > +       notmuch-hello-refresh-hook-counter)'
> > +)
> > +test_expect_equal "$counter" 1
> > +
> > +test_begin_subtest "notmuch-hello-refresh hook is called on updates"
> > +counter=$(test_emacs \
> > +    '(let ((notmuch-hello-refresh-hook-counter 0))
> > +       (kill-buffer "*notmuch-hello*")
> > +       (notmuch-hello)
> > +       (notmuch-hello-update)
> > +       notmuch-hello-refresh-hook-counter)'
> > +)
> > +test_expect_equal "$counter" 2
> > +
> >  test_done
> > diff --git a/test/test-lib.el b/test/test-lib.el
> > index 83b8a65..3b817c3 100644
> > --- a/test/test-lib.el
> > +++ b/test/test-lib.el
> > @@ -75,3 +75,4 @@ nothing."
> >    (add-hook hook (apply-partially 'hook-counter hook)))
> >  
> >  (add-hook-counter 'notmuch-hello-mode-hook)
> > +(add-hook-counter 'notmuch-hello-refresh-hook)
> > -- 
> > 1.7.7.3
> > 
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch
> 
> -- 
> Thomas/Schnouki