From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>, David Bremner <david@tethera.net>
Subject: Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch
	reply"
In-Reply-To:
 <CAB+hUn9cWzDYK7ZvKWvsU=cCNuU80ERR8gT+T_Tu=SfMXH7K5A@mail.gmail.com>
References: <cover.1325794371.git.jani@nikula.org>
	<974a2ef1f1df7d93e0b5bd642ca8a49f8b727a86.1325794371.git.jani@nikula.org>
	<87sjjsjhjk.fsf@zancas.localnet>
	<CAB+hUn9cWzDYK7ZvKWvsU=cCNuU80ERR8gT+T_Tu=SfMXH7K5A@mail.gmail.com>
User-Agent: Notmuch/0.10.2+183~g99cd7be (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Sat, 07 Jan 2012 11:57:39 +0000
Message-ID: <877h13u3m4.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list


Hello

I do not get the failure with just 1/4 applied but do with all 4
applied. The trivial patch below fixes it, but it might not be the best
solution.

The failure occurs because Jani's patch changes the behavior of a couple
of emacs/notmuch internal functions: the function
notmuch-search-reply-to-thread is renamed to
notmuch-search-reply-all-to-thread and a new
notmuch-search-reply-to-thread function is added (which does reply to
sender) and a similar change for notmuch-show-reply-.. . Since the
keybindings are also remapped the user will not notice any difference.

However, if the user has any key-bindings etc in their .emacs file the
behaviour could change. It might be preferable to keep the existing
functions as they are and give the new reply-to-sender functions a new
name.

Best wishes

Mark


diff --git a/test/emacs b/test/emacs
index a06c223..5047d46 100755
--- a/test/emacs
+++ b/test/emacs
@@ -258,7 +258,7 @@ test_expect_equal_file OUTPUT EXPECTED
 test_begin_subtest "Reply within emacs"
 test_emacs '(notmuch-search "subject:\"testing message sent via SMTP\"")
 	    (notmuch-test-wait)
-	    (notmuch-search-reply-to-thread)
+	    (notmuch-search-reply-all-to-thread)
 	    (test-output)'
 sed -i -e 's/^In-Reply-To: <.*>$/In-Reply-To: <XXX>/' OUTPUT
 cat <<EOF >EXPECTED