From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME
	traversal.
In-Reply-To: <1324698348-27620-3-git-send-email-amdragon@mit.edu>
References: <1323460468-4030-1-git-send-email-amdragon@mit.edu>
	<1324698348-27620-1-git-send-email-amdragon@mit.edu>
	<1324698348-27620-3-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.10.2+127~g6689686 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Fri, 23 Dec 2011 23:55:34 -0800
Message-ID: <87y5u2jte1.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> +    /* True if decryption of this part was attempted. */
> +    notmuch_bool_t decrypt_attempted;
> +    /* True if decryption of this part's child succeeded.  In this
> +     * case, the decrypted part is substituted for the second child of
> +     * this part (which would usually be the encrypted data). */
> +    notmuch_bool_t decrypt_success;
> +
> +    /* True if signature verification on this part was attempted. */
> +    notmuch_bool_t sig_attempted;

I think these new variables make sense, and reflect the correct
semantics, as you already mentioned.

I do, however, think the later variable should be called
"verify_attempted" (or "verification_", or "ver_"?), instead of
"sig_attempted", since verification is the complementary action on a
signed part, just as decryption is for an encrypted one.
"sig_attempted" somehow implies to me that one is trying to make a
signature, not verify an existing one.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJO9YV2AAoJEO00zqvie6q8E1YP/igtKzcsiKYkfKXr7hlzqDhW
vPsdpWLCsdZSRgBu0/4g1stj1GM8zHhi0JEEp/85+t0ZINncDvLeSN2U8+LiODgO
IOZ5mP4oFGnRyh3IrIDstNgXfzhyYifMfkoDM78y46K8PXdMXcl34wJxwOM59NCE
EzhfRrsFr0KoQ+uxQofDg/OzCP8ZMv1UqtK3ZfwVS7nzwh9pJJ8JU4L+LWFlgufJ
aUAaIfmShCUyoCDBph9tMIp9wsnfz69p3gcZhY2U2pqZ6/FACKH9WwF08Ae6AEfD
4RsbjQFppbOuKtXeqEzyRzw6ZNKRhxuUUXqRIRj2Uh9+Hbss59jRVS+uVE4jEq4S
wdqf/Q1Brs4L25v9rNM2muRv/Qot4JUZTOCFTHQcDEOWqY3W/AS/FmJWq4w5ALSb
DgTo+6LR8gquhp6gqwDXJZG0tXmZtyF+uXZLa+9cwJprGlDRfsvoWZcuwFHEbt9p
9klMgWTfYb2ejUFDTNkqrXro+hcrAJCkp2BSVlRQLgBSqWbG/T9hzuWHjx5Gspc3
b0nslB9TM1Sd2A+PMCGWJiHL+lkORCzBMnFOboLIZWV920MiKA1JacsxQ7ZOlRLK
5bfhxmJblLzachQMon52mk3hfB883KbbqwWV8MWrcAoYJfR8KDYqFFleHEL+hFIK
FNmBBf9TUKit4K4NYEwv
=uCt3
-----END PGP SIGNATURE-----
--=-=-=--