Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 243D3431FAF for ; Sat, 28 Jul 2012 10:02:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NQ5obUly7ziz for ; Sat, 28 Jul 2012 10:01:59 -0700 (PDT) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4E5ED431FAE for ; Sat, 28 Jul 2012 10:01:59 -0700 (PDT) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1SvAOp-000195-Ka; Sat, 28 Jul 2012 18:01:55 +0100 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1SvAOp-0005CQ-AZ; Sat, 28 Jul 2012 18:01:55 +0100 From: Mark Walters To: notmuch@notmuchmail.org Subject: Re: [PATCH 2/5] emacs: make notmuch-show return its buffer In-Reply-To: <1343164911-31589-3-git-send-email-markwalters1009@gmail.com> References: <1343164911-31589-1-git-send-email-markwalters1009@gmail.com> <1343164911-31589-3-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.13.2+93~gf33b188 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Sat, 28 Jul 2012 18:01:49 +0100 Message-ID: <87ipd7vmyq.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 5415b7a046be7f9ba70630b11d927240 (of first 20000 bytes) X-SpamAssassin-Score: -1.8 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.8 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay * domain * 0.5 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jul 2012 17:02:00 -0000 Hi I have a version 2 of the rest of this series. However, it obviously conflicts with the two patches I submitted today splitting out the async-json parser and the clean-author function. Hence I will see how they are received before submitting version 2. I will mark Patches 3-5 obsolete (and have already marked 1 obsolete as Tomi had a much better way of doing it). However Patch 2/5 will be needed in any case so review/approval for this one-line patch would be great! Many thanks Mark On Tue, 24 Jul 2012, Mark Walters wrote: > notmuch-pick uses the returned buffer to try and make sure it does not > close the wrong buffer. > --- > emacs/notmuch-show.el | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 6335d45..1cabd17 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -1031,7 +1031,8 @@ function is used." > notmuch-show-parent-buffer parent-buffer > notmuch-show-query-context query-context) > (notmuch-show-build-buffer) > - (notmuch-show-goto-first-wanted-message))) > + (notmuch-show-goto-first-wanted-message) > + (current-buffer))) > > (defun notmuch-show-build-buffer () > (let ((inhibit-read-only t)) > -- > 1.7.9.1