Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EAD61431FBC for ; Wed, 25 Nov 2009 13:25:07 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jH785kRr43dc for ; Wed, 25 Nov 2009 13:25:07 -0800 (PST) Received: from mail-ew0-f213.google.com (mail-ew0-f213.google.com [209.85.219.213]) by olra.theworths.org (Postfix) with ESMTP id 27AAE431FAE for ; Wed, 25 Nov 2009 13:25:07 -0800 (PST) Received: by ewy5 with SMTP id 5so146164ewy.30 for ; Wed, 25 Nov 2009 13:25:06 -0800 (PST) Received: by 10.213.37.199 with SMTP id y7mr8312550ebd.36.1259184305580; Wed, 25 Nov 2009 13:25:05 -0800 (PST) Received: from x61s.janakj ([213.192.30.141]) by mx.google.com with ESMTPS id 10sm237233eyz.23.2009.11.25.13.25.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 25 Nov 2009 13:25:03 -0800 (PST) Received: by x61s.janakj (Postfix, from userid 1000) id 84B56440655; Wed, 25 Nov 2009 22:25:01 +0100 (CET) Date: Wed, 25 Nov 2009 22:25:01 +0100 From: Jan Janak To: Bart Trojanowski Message-ID: <20091125212501.GF25119@ryngle.com> References: <1259100630-13673-5-git-send-email-jan@ryngle.com> <1259174251-27298-1-git-send-email-jan@ryngle.com> <20091125195520.GG29312@jukie.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091125195520.GG29312@jukie.net> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH] notmuch-new: Option to disable tags from the configuration file. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Nov 2009 21:25:08 -0000 Hi Bart, On 25-11 14:55, Bart Trojanowski wrote: > Jan, > > I think your use of STRNCMP_LITERAL here is wrong... > > > + } else if (STRNCMP_LITERAL (argv[i], "--no-config-tags") == 0) { > > + add_config_tags = 0; > > it will happily match "--no-config-tags-xxxxxxxxxxxxxxxxxxx". Ahh, I actually stole the code from the part which parses the --verbose command line option. And I didn't check it. That one suffers from the same problem, so I'll just fix them both in one patch. > Can I also suggest including --no-config-tags in the 'notmuch help' > output? Sure, I'll add it. > Besides that I am very happy with this patch series. Thanks a lot! -- Jan