Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EF81A431FAF for ; Sat, 13 Apr 2013 04:53:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ujh8BnAxHKDp for ; Sat, 13 Apr 2013 04:53:06 -0700 (PDT) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 1C32C431FAE for ; Sat, 13 Apr 2013 04:53:06 -0700 (PDT) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1UQz0u-0002jJ-Ql; Sat, 13 Apr 2013 08:53:01 -0300 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1UQz0p-0001FX-3j; Sat, 13 Apr 2013 08:52:55 -0300 From: David Bremner To: Mark Walters , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions In-Reply-To: <87eheekjgp.fsf@qmul.ac.uk> References: <1365630175-1048-1-git-send-email-tomi.ollila@iki.fi> <87eheekjgp.fsf@qmul.ac.uk> User-Agent: Notmuch/0.15.2+73~g1c450ec (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Sat, 13 Apr 2013 08:52:54 -0300 Message-ID: <87mwt2ve95.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Apr 2013 11:53:07 -0000 Mark Walters writes: > On Wed, 10 Apr 2013, Tomi Ollila wrote: >> Some (declare-function ...) definitions were drifted away from the >> actual (defun ...)'s. To find the drifts and to verify changes >> the following command line was used: >> >> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")' > > This patch looks good to me +1. > > Is it worth making the above command into a test? Maybe a release check? d