From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Carl Worth <cworth@cworth.org>, Gregor Hoffleit <gregor@hoffleit.de>,
	notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] First tests for JSON output and UTF-8 in mail body and
	subject
In-Reply-To: <878w8ofpx9.fsf@yoom.home.cworth.org>
References: <1267697893-sup-4538@sam.mediasupervision.de>
	<87r5mje55l.fsf@yoom.home.cworth.org>
	<1271176622-sup-4680@sam.mediasupervision.de>
	<87iq7tft7j.fsf@yoom.home.cworth.org>
	<87ochlt8r9.fsf@steelpick.2x.cz>
	<878w8ofpx9.fsf@yoom.home.cworth.org>
Date: Fri, 16 Apr 2010 10:17:15 +0200
Message-ID: <87vdbrerqs.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

> But you might actually like that change since it's one you requested in
> your first version of the modular test suite. I'm dropping the annoying
> execute_expecting macro that both runs notmuch and tests the
> output. There's now a much cleaner separation such as:
> 
> 	output=$($NOTMUCH search for-something)
> 	pass_if_equal "$output" "something was found"

It's definitely better than before. The current implementation of
pass_if_equal has IMHO one drawback - if it compares multiline text and
there is a difference, it is quite hard to see where.

In my tests for maildir synchronization I use this approach:

  notmuch search tag:inbox | filter_output > actual &&
  diff -u - actual <<EOF
  thread:XXX   2000-01-01 [1/1] Notmuch Test Suite; test message 3 (inbox)
  EOF

Thanks to the usee of diff, I immediately see only the differences.

-Michal