From: Jesse Rosenthal <jrosenthal@jhu.edu>
To: "W. Trevor King" <wking@tremily.us>
Subject: Re: [PATCH] test: Make gen-threads work with python3
In-Reply-To: <20141031174153.GQ15443@odin.tremily.us>
References: <1414776805-30000-1-git-send-email-jrosenthal@jhu.edu>
	<20141031174153.GQ15443@odin.tremily.us>
User-Agent: Notmuch/0.18.2+156~g1f413d7 (http://notmuchmail.org) Emacs/24.4.1
	(i686-pc-linux-gnu)
Date: Fri, 31 Oct 2014 14:04:50 -0400
Message-ID: <87bnosdsjh.fsf@jhu.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

"W. Trevor King" <wking@tremily.us> writes:

> On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote:
>> We instead initalize the dictionary using the dict comprehension and
>> then update it with the values from the tree. This will work with
>> both python2 and python3.
>
> Dict comprehensions are new in 2.7 [1,2], so this drops support for
> systems where =E2=80=98python=E2=80=99 means =E2=80=98python2.6=E2=80=99.=
  Personally, I'm fine with
> that, but I thought I'd point it out in case 2.6 users wanted to push
> back ;).

The comprehension was already in the previous version, so I figured that
people were already cool with 2.7+.

>> -
>>  import sys
>
> Why remove this blank line?

Oops -- I had put in a print_function import from __future__ for
testing. Must have lost the line when I took it back out. Is it worth
resubmitting to fix that?