Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0A6B4431FAF for ; Sat, 31 Mar 2012 14:47:11 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LgG2oZBcA2t5 for ; Sat, 31 Mar 2012 14:47:10 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 96B28431FAE for ; Sat, 31 Mar 2012 14:47:10 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 141752E50B6E; Sat, 31 Mar 2012 14:47:08 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (unknown [76.89.193.65]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 53CFF2E50D08; Sat, 31 Mar 2012 14:47:04 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id E2FE22F5; Sat, 31 Mar 2012 14:47:03 -0700 (PDT) From: Jameson Graef Rollins To: Mark Walters , Peter Wang , notmuch@notmuchmail.org Subject: Re: [PATCH v2 2/5] test: Add tests for 'config' command In-Reply-To: <877gy1p622.fsf@qmul.ac.uk> References: <1332282698-7951-1-git-send-email-novalazy@gmail.com> <1333149350-22616-1-git-send-email-novalazy@gmail.com> <1333149350-22616-3-git-send-email-novalazy@gmail.com> <877gy1p622.fsf@qmul.ac.uk> User-Agent: Notmuch/0.12+93~g9442054 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 31 Mar 2012 14:47:01 -0700 Message-ID: <87wr60moiy.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Mar 2012 21:47:11 -0000 --=-=-= On Sat, Mar 31 2012, Mark Walters wrote: > It seems off to call is success without checking that the value has > actually been set. Of course it is checked in the notmuch config list > test introduced in the next commit but I think if it would be better to > check with notmuch config get here too (i.e. check that reading back the > value gives what you want). Otherwise a failure in `setting' will show up > as a test failure in `listing'. Hey, Peter. I think Mark makes a good point here. I think it would make more sense for the test to set the value, and then check that the value is properly set as expected. It would make the tests multi-step, but that's fine. There's plenty of precedent for that. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJPd3tVAAoJEO00zqvie6q84E8P+gKOwSmKz8OyXLQPqr6BL6b8 q9KTnad3cVfNSY8aY0fFAYI1RAEMFQSejrdxjir/JniJCZvnNOe1g9gxvCHijXmM sBTA2LQCUWndx7jJLDXMmvP2764JuuBtm3Qr30CEIyUTGUkmfmzuJsPSlPkzlf7e 01QLEmOwcCqleh0fziCDwb9oD67d6kPUi5EB6E+3lvgxjQMXS9eogBDdb2nchsbM 7JV8y+c/2dIhWxOnKYqcAVDqO3BJujQXvID3U4RlvydE2d+t8dfBfeZnkSiBL+IR /I179cgqg6sPKaNFpzYI+BIaegwki9mfYtjp5hKUsRYRsuyo8cmMIGhYpCagHf4J /FUilqIdIeO8D4/4MY/OuNiqQZ6dN2reFFEwJGuhmqyrWa4QgVcUjbIsjQI73oqX l59GKzEw+pjbOgxfpb+gGsGBkgWXQJ5TQVB3n276UNtN2yscmJlXTfBHNZwdWuCe OW5ZNsB6nl++cgy3VTOVKWbz/SwZXHdbll7Bwj2NqnNfasIW0AR8bqCwEhgZIpXO 3fd6kyy634UUz9L+jm1geQ+YTi+2+2Kibm9AMPew6/rGEgxGAllXXZfPEqgYYVqf 2w40dIzHJ/eK5ahAFFgOlmhhUuc5KMadJ5Jb6rAXx3bMkwJUKDKkYmeZCyaah5Ft Dl2fgLDKLe4vn50lUw0w =uW5e -----END PGP SIGNATURE----- --=-=-=--