From: Jani Nikula <jani@nikula.org>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: v3 of testing for new tagging/dump/restore
In-Reply-To: <1354455204-6908-1-git-send-email-david@tethera.net>
References: <1354455204-6908-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.14+124~g3b17402 (http://notmuchmail.org) Emacs/23.4.1
	(i686-pc-linux-gnu)
Date: Sun, 02 Dec 2012 17:44:56 +0200
Message-ID: <87lidgcvbb.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


LGTM,
Jani.

On Sun, 02 Dec 2012, david@tethera.net wrote:
> Here is round 3 of the batch tagging stuff, but just the first six
> patches, which are more or less useful without the remaining one
> (although a bit epic if the only goal is add a single test).
>
> Detailed list of changes follows, the first one is a change to the
> encoding format.  Looking forward to maybe doing tricks with maildirs
> and hardlinks, it seems like we might want to encode ':'. The fact
> that it might help MacOS X users we can consider neutral ;).
>
> - hex-escape.c: escape ':'
> - hex-escape.c: simpler buffer size calculations.
> - hex-xcode.c: uncrustify + delete extra blank lines
> - hex-xcode.c: provide inplace mode for test coverage
> - test/hex-escaping, copy tests for --in-place version of test
> - test/database-test.c: only thaw if we froze
> - random-corpus.c: use a table based scheme to favour shorted code points
> - random-corpus.c: uncrustify
> - random-corpus.c: delete blank line, reorder while loop
> - update roundtrip test to avoid need for random-corpus tag.
> - do not add tag "random-corpus" in random-corpus.c
>
> Things that I (knowingly) ignored
>
> - Jani suggested an extra talloc in random-corpus.c
> - I left the argument format of hex-xcode alone
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch