Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C2F62431FC3 for ; Mon, 1 Mar 2010 09:30:14 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.568 X-Spam-Level: X-Spam-Status: No, score=-0.568 tagged_above=-999 required=5 tests=[AWL=0.172, BAYES_20=-0.74] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fqUEuvJE+nrV for ; Mon, 1 Mar 2010 09:30:14 -0800 (PST) Received: from pivot.cs.unb.ca (pivot.cs.unb.ca [131.202.240.57]) by olra.theworths.org (Postfix) with ESMTP id 3BC41431FBD for ; Mon, 1 Mar 2010 09:30:14 -0800 (PST) Received: from fctnnbsc30w-142167166109.pppoe-dynamic.high-speed.nb.bellaliant.net ([142.167.166.109] helo=rocinante.cs.unb.ca) by pivot.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Nm9RV-0004zG-3B; Mon, 01 Mar 2010 13:30:05 -0400 Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.71) (envelope-from ) id 1Nm9OO-0006yW-GY; Mon, 01 Mar 2010 13:26:52 -0400 From: David Bremner To: Sebastian Spaeth , notmuch@notmuchmail.org In-Reply-To: <1267457946-30347-1-git-send-email-Sebastian@SSpaeth.de> References: <87r5o49kow.fsf@SSpaeth.de> <1267457946-30347-1-git-send-email-Sebastian@SSpaeth.de> Date: Mon, 01 Mar 2010 13:26:52 -0400 Message-ID: <878wacrm03.fsf@rocinante.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Verified: bremner@pivot.cs.unb.ca Subject: Re: [notmuch] [PATCH] notmuch-show: add tags to json output X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2010 17:30:14 -0000 On Mon, 1 Mar 2010 16:39:06 +0100, Sebastian Spaeth wrote: > The previous json patches forgot to add the notmuch tags to the json > output. This is inconsistent to the text output so here they are. We > just output a 'tags' field that sends a space delimited list of > json-encoded notmuch tags. > > Signed-off-by: Sebastian Spaeth I agree we need tags in json output, but I think that making the client parse the string of (space delimited?) tags defeats a bit the purpose of having json output. What do you think about "tags": [ "inbox", "unread" ] instead of "tags": "inbox unread"