Date: Mon, 16 Jan 2012 14:28:36 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: David Edmondson <dme@dme.org>
Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions
Message-ID: <20120116192836.GC16740@mit.edu>
References: <1326258173-21163-1-git-send-email-amdragon@mit.edu>
	<1326496024-14403-1-git-send-email-amdragon@mit.edu>
	<1326496024-14403-4-git-send-email-amdragon@mit.edu>
	<87wr8tsvit.fsf@servo.finestructure.net>
	<cunfwfg57uh.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cunfwfg57uh.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth David Edmondson on Jan 16 at  9:12 am:
> On Sat, 14 Jan 2012 15:40:26 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > This patch looks fine.  Philosophical UI discussion to follow:
> > 
> > On Fri, 13 Jan 2012 18:07:04 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > > +    if (notmuch_config_get_auto_exclude_tags (config, &tmp) == NULL) {
> > > +	const char *tags[] = { "deleted", "spam" };
> > > +	notmuch_config_set_auto_exclude_tags (config, tags, 2);
> > > +    }
> > 
> > This creates the config section with the exclude list pre-set to
> > "deleted;spam".
> 
> I don't think that anything should be excluded from the search results
> by default, at least not as a default behaviour of the 'notmuch'
> binary.
> 
> Having "deleted" and "spam" as default settings in the configuration
> file might be more reasonable.

Sorry, I'm confused.  Are you saying deleted;spam should or should not
be the default?