Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 60724431FBF; Tue, 17 Nov 2009 12:19:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j+ZeUopdCH+8; Tue, 17 Nov 2009 12:19:40 -0800 (PST) Received: from cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 58221431FAE; Tue, 17 Nov 2009 12:19:39 -0800 (PST) From: Carl Worth To: Alex Botero-Lowry , notmuch@notmuchmail.org In-Reply-To: References: Date: Tue, 17 Nov 2009 12:19:24 -0800 Message-ID: <87lji4lx9v.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [notmuch] preliminary FreeBSD support X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2009 20:19:41 -0000 On Tue, 17 Nov 2009 11:36:14 -0800, Alex Botero-Lowry wrote: > I saw the announcement this morning, and was very excited, as I had been > hoping sup would be turned into a library, > since I like the concept more than the UI (I'd rather an emacs interface). Hi Alex, That's great! It's good to hear that there are like-minded people out there. I hope that Notmuch will be useful for you. > I did a preliminary compile which worked out fine, but > sysconf(_SC_SC_GETPW_R_SIZE_MAX) returns -1 on > FreeBSD, so notmuch_config_open segfaulted. > > Attached is a patch that supplies a default buffer size of 64 in cases where > -1 is returned. Thanks for the patch. As we discussed in IRC[*], we should probably do the correct thing and check for ERANGE and loop as necessary (even if sysconf returns a positive value). Example code here: http://www.opengroup.org/austin/docs/austin_328.txt -Carl [*] #notmuch on irc.freenode.net for those who didn't just guess that already, (and I'll add that to the website soon).