From: Carl Worth <cworth@cworth.org>
To: Mark Anderson <ma.skies@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] search --output=files: Output all filenames for each
	matching message
In-Reply-To: <87fwmtahxn.fsf@yoom.home.cworth.org>
References: <878vsqdd4w.fsf@gmail.com> <87fwmtahxn.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Tue, 28 Jun 2011 12:20:31 -0700
Message-ID: <87d3hxahkw.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Tue, 28 Jun 2011 12:12:52 -0700, Carl Worth <cworth@cworth.org> wrote:
> I think the only thing I would like to see in addition is an update to
> the documentation to make it explicit that --output=3Dfiles will emit all
> filenames for a message that has more than one filename.

Actually, I went to go update the documentation itself, and I found that
it doesn't really need anything new here. The current text is:

	--output=3Dfiles

	Output the filenames of all messages matching the search terms,
        either one per line (--format=3Dtext) or as a JSON array
        (--format=3Djson).

And that's pretty clearly "the filenames of all messages".

The fact that we share a single "message object" when two files contain
the same message-id seems like an implementation detail that's not worth
bringing up here. (It would add more concepts to the documentation but
not actually change the meaning.)

So I've pushed the test and fix as-is now.

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4KKX8ACgkQ6JDdNq8qSWg2FwCfYHckCLmjMmDh9j6B5w0Ed6eN
U0wAn1Mhq/KY6aK5vQioWjXgHg92vys6
=rRS2
-----END PGP SIGNATURE-----
--=-=-=--