Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5923A431FAE for ; Tue, 17 Apr 2012 02:30:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jMPlOFCFekqi for ; Tue, 17 Apr 2012 02:30:28 -0700 (PDT) Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7DCCF431FB6 for ; Tue, 17 Apr 2012 02:30:28 -0700 (PDT) Received: by qcsk26 with SMTP id k26so4634033qcs.26 for ; Tue, 17 Apr 2012 02:30:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type:x-gm-message-state; bh=HqUQckzPItOR1oG4QbhLYa6zTmeH8btH1M+KmDuBlHk=; b=GaOAUzRPnm5f0fNReLDqnk4glgTOw40z2jlis7uW7/+xc62xGB0/ZB6+U0o1Njent8 gJ4jHzol/lpSwOYTa47g99uZFWWyhyfFO9BEw6ae8qqyWJFnELECpL/VMfYTVN6jXB1W 8jV8wpFjusacc2kq0zhZ8lmU3CzZHi6d9mMQpLAo38sRJUlRGlfl8mu2mPynXjrILUmJ R4P0T19ZvjruFRHnl0x1SK+odLZtVf96Sg32PCrXzW/UjTc+xFyISse4+LEDSquP6i2/ jeMtTiMwq4LhgtUXlLXg+TFK/c8RrKVB7dMpLiu0pP3+QfAK9xWsv3s2YIEtQh24j+LV bZ2A== Received: by 10.229.135.209 with SMTP id o17mr1459884qct.152.1334655027784; Tue, 17 Apr 2012 02:30:27 -0700 (PDT) Received: from localhost (nikula.org. [92.243.24.172]) by mx.google.com with ESMTPS id fo9sm39250891qab.21.2012.04.17.02.30.26 (version=SSLv3 cipher=OTHER); Tue, 17 Apr 2012 02:30:27 -0700 (PDT) From: Jani Nikula To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook In-Reply-To: <877gxeohh6.fsf@gmail.com> References: <21f129a3426c58d44fed7150b32c4fec7021bda0.1334651669.git.jani@nikula.org> <877gxeohh6.fsf@gmail.com> User-Agent: Notmuch/0.11.1+222~ga47a98c (http://notmuchmail.org) Emacs/23.1.1 (i686-pc-linux-gnu) Date: Tue, 17 Apr 2012 09:30:24 +0000 Message-ID: <87hawivh73.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Gm-Message-State: ALoCoQko6/OkeJD6f3KlQR+sA0qlTeX3vh8XNxNF6jyZncEWe6gNwlN8xb1YAmibea5UuxP/4jkf X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2012 09:30:32 -0000 On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin wrote: > Can you please give some explanaition why is this needed? Would this > change break custom hooks that do not expect any arguments? For patch 3/4. We don't want to display a message if someone calls (notmuch-hello-update t) from some script, and notmuch-hello buffer isn't even visible. Yes, it would break custom hooks. And a bunch of tests. But I think it would be useful for custom hooks too, for the same reason as above. Jani. > > Regards, > Dmitry > > Jani Nikula writes: > > > --- > > emacs/notmuch-hello.el | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > > index 9cd907a..0596bbe 100644 > > --- a/emacs/notmuch-hello.el > > +++ b/emacs/notmuch-hello.el > > @@ -776,7 +776,7 @@ following: > > (widget-setup) > > > > (goto-char final-target-pos)) > > - (run-hooks 'notmuch-hello-refresh-hook) > > + (run-hook-with-args 'notmuch-hello-refresh-hook no-display) > > (setq notmuch-hello-first-run nil)) > > > > (defun notmuch-folder () > > -- > > 1.7.1 > > > > _______________________________________________ > > notmuch mailing list > > notmuch@notmuchmail.org > > http://notmuchmail.org/mailman/listinfo/notmuch