From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to
	know
In-Reply-To: <87390nid3c.fsf@betacantrips.com>
References: <1351865226-916-1-git-send-email-tomi.ollila@iki.fi>
	<87390nid3c.fsf@betacantrips.com>
User-Agent: Notmuch/0.14+81~gb8371cd (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
Date: Tue, 06 Nov 2012 09:07:22 +0200
Message-ID: <m2objb9plh.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Tue, Nov 06 2012, Ethan Glasser-Camp <ethan.glasser.camp@gmail.com> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> Added FILE, notmuch_show_params_t and sprinter_t to be
>> types when uncrustifying sources. This affect spacing
>> when uncrustify is deciding for type declaration instead
>> of binary multiplication operation.
>
> This looks good to me. If you had plenty of time and no more patches to
> review, I'd prefer the slightly cleaner English:
>
> This affects how uncrustify puts spacing around pointers to these types,
> since it can parse them as type declarations instead of binary
> multiplication operations.
>
> ... but even suggesting this indicates I've moved past the bike shed and
> into somebody else's kitchen.

I always appreciate anybody putting effort to translate my scrawls into
more cleaner expressions ;D

If the change were more important I'd take time to improve the commit
message.

Like one of our famous contributors have said:

"I also don't think we have to be totally obsessive about our commit history."

and

"I doubt it would make much difference in the grand scheme of things."

:D

> Ethan

Thanks, 

Tomi