From: Jani Nikula <jani@nikula.org>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 2/2] cli: convert "notmuch new" to the argument parser
In-Reply-To: <20121203222844.GH1020@mit.edu>
References:
 <c4f2a1048763950dd14e13c99a4e7eb333be8c9d.1354568072.git.jani@nikula.org>
	<e31ac6b2ceed533f8ac5386a010f4c052e09502e.1354568072.git.jani@nikula.org>
	<20121203222844.GH1020@mit.edu>
User-Agent: Notmuch/0.14+137~g9203c35 (http://notmuchmail.org) Emacs/23.4.1
	(i686-pc-linux-gnu)
Date: Tue, 04 Dec 2012 00:35:46 +0200
Message-ID: <87y5he9325.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Precedence: list

On Tue, 04 Dec 2012, Austin Clements <amdragon@MIT.EDU> wrote:
>> -    argc--; argv++; /* skip subcommand argument */
>> +    notmuch_opt_desc_t options[] = {
>> +	{ NOTMUCH_OPT_BOOLEAN,  &add_files_state.verbose, "verbose", 'v', 0 },
>> +	{ NOTMUCH_OPT_BOOLEAN,  &add_files_state.debug, "debug", 'd', 0 },
>> +	{ NOTMUCH_OPT_BOOLEAN,  &no_hooks, "no-hooks", 'n', 0 },
>
> Not that the single character arguments matter right now, but '-n' is
> often used for "dry-run", which could actually apply to notmuch new.

Agreed, although I believe we'd have to review all of the single
character arguments before actually enabling any of them. At least my
choice of them has been rather whimsical. I'll leave this up to David to
decide.

BR,
Jani.