Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C9891431FD0 for ; Fri, 3 Jun 2011 16:15:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D4Zh+AzmqUbq for ; Fri, 3 Jun 2011 16:15:22 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 18670431FB6 for ; Fri, 3 Jun 2011 16:15:22 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 1386729A5CC; Fri, 3 Jun 2011 16:15:21 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id 031C425417E; Fri, 3 Jun 2011 16:15:21 -0700 (PDT) From: Carl Worth To: Daniel Kahn Gillmor , notmuch@notmuchmail.org Subject: Re: [PATCH] Always return the empty string if decryption tries to demand a password In-Reply-To: <1307142188-6551-1-git-send-email-dkg@fifthhorseman.net> References: <87lixr1w87.fsf@yoom.home.cworth.org> <1307142188-6551-1-git-send-email-dkg@fifthhorseman.net> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Fri, 03 Jun 2011 16:15:14 -0700 Message-ID: <8762omld6l.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: Daniel Kahn Gillmor X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2011 23:15:22 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 3 Jun 2011 19:03:08 -0400, Daniel Kahn Gillmor wrote: > The notmuch binary is not in the business of doing interactive > prompting with the user. If credentials are needed for decryption, > they should be supplied to the decrypting processes some other way > (e.g. gpg-agent). >=20 > Previously, we returned a NULL function pointer for the > request_passwd() function, which may have cause segmentation faults > with some versions of gmime. Cool. This fixes my segfaults, so thanks! > + return g_strdup (""); Is the above correct? Or is it a memory leak? (If it's not a leak, then GMime really has some bizarre ownership semantics.) =2DCarl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3pawIACgkQ6JDdNq8qSWgi3QCfQETiY10Hyd+iZNvffXyTpw59 JMYAn26z8RsXAtzFmGnn9pYIB/JJ+ccL =MPn8 -----END PGP SIGNATURE----- --=-=-=--