Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7CB76431FB6 for ; Fri, 27 Jan 2012 00:44:23 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KmMKjOHd62dy for ; Fri, 27 Jan 2012 00:44:23 -0800 (PST) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B9BBD431FAE for ; Fri, 27 Jan 2012 00:44:22 -0800 (PST) Received: by wibhi8 with SMTP id hi8so1137480wib.26 for ; Fri, 27 Jan 2012 00:44:21 -0800 (PST) Received: by 10.180.109.198 with SMTP id hu6mr10057651wib.16.1327653861516; Fri, 27 Jan 2012 00:44:21 -0800 (PST) Received: from localhost ([109.131.116.159]) by mx.google.com with ESMTPS id df2sm10164533wib.4.2012.01.27.00.44.20 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 27 Jan 2012 00:44:20 -0800 (PST) From: Pieter Praet To: David Edmondson Subject: Re: [RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'. In-Reply-To: References: <87pqe6vcgv.fsf@praet.org> <1327583610-30085-1-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Fri, 27 Jan 2012 09:42:23 +0100 Message-ID: <878vkt35ao.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2012 08:44:23 -0000 On Thu, 26 Jan 2012 14:40:26 +0000, David Edmondson wrote: > In general, I like this. > > - I think that the stash function(s) should take an optional argument > specifying the archive to use. That will make testing simpler and also > allow people to produce preferred bindings more easily. > Agreed. In fact, apparently that last patch [1] of mine made the test suite hang @ emacs:"Stashing in notmuch-show" due to it waiting for `completing-read' to finish... Sorry for that. > - "Message archive: " feels better than "ML Archive: ", but I don't > really care. > Agreed. > - Don't base the patch on the thing that I posted, just on master from > the repository - no need to make David's life harder. Seeing as how it was only a minor improvement to your idea (and further discussion/correction was probably appropriate), I intended for you to squash it into your original patch. Anyways, patch (relative to master) follows... Peace -- Pieter [1] id:"1327583610-30085-1-git-send-email-pieter@praet.org"