Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 28620431FB6 for ; Thu, 28 Jun 2012 11:39:58 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.798 X-Spam-Level: X-Spam-Status: No, score=-0.798 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7lnYFTwviCAR for ; Thu, 28 Jun 2012 11:39:57 -0700 (PDT) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 99F04431FAF for ; Thu, 28 Jun 2012 11:39:57 -0700 (PDT) Received: by vcbf1 with SMTP id f1so2041978vcb.26 for ; Thu, 28 Jun 2012 11:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9QWQSQOqFJf5LlXpHCjt64t9poqfaknFP1fYUoBtfSc=; b=TmRUpE4X0nGMhAOoqxrtwGJf41lsI0SVR9tejc5nzV2JEw5x7mg9wzGsxbGla+FIXe ih1ZiGpXtv7DJ2hzuRAWGbGoCOjqWXf/nqfKaZHjw/yqtiwh60FgY6brtiFb/R24h26F 86EuK4ssDxh+3t2mFapb0XZhWH+Llkk6Mzi7UtsDAz8ktbzbPO4Bu0PvY0ivAn/NZAZ+ KXqbEqFq8gWsUK+J3T4ZFz1YN1/w2eDpUiiQ3w65LcttDOz3tF9ZwEpLPtvHSsj8LAkm xFXWU0O56pFk9Sn+BTF1+n/xSMr7dpvaB243ZjvkvsahEUzzRDQD65NQlp54RKmXnZhu ikdQ== MIME-Version: 1.0 Received: by 10.52.92.49 with SMTP id cj17mr2154481vdb.21.1340908795775; Thu, 28 Jun 2012 11:39:55 -0700 (PDT) Received: by 10.220.6.3 with HTTP; Thu, 28 Jun 2012 11:39:55 -0700 (PDT) In-Reply-To: <87txxvuyn4.fsf@servo.finestructure.net> References: <1340656899-5644-1-git-send-email-ethan@betacantrips.com> <87txxvuyn4.fsf@servo.finestructure.net> Date: Thu, 28 Jun 2012 14:39:55 -0400 Message-ID: Subject: Re: [RFC PATCH 00/14] modular mail stores based on URIs From: Ethan To: Jameson Graef Rollins Content-Type: multipart/alternative; boundary=20cf3071ce1472ccaa04c38ca8f2 Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2012 18:39:58 -0000 --20cf3071ce1472ccaa04c38ca8f2 Content-Type: text/plain; charset=ISO-8859-1 It is pretty big and there are a couple places where the series could be simplified, the first patch in particular. I will break it out and resubmit piecewise but I'd like to know how to address these particular issues: 1. Are URIs the way to specify individual messages, despite bremner's concerns about too much of the API being strings? Is adding another library is the easiest way to parse URIs? 2. Is it OK to break maildir relocatability, or is it worth it to pass more config to the library (perhaps by adding it to the notmuch_database_t object)? 3. Is a global variable in the library acceptable? (I don't see any others.) If not, how to store mailstore state? The patch series is really more like a very rough draft to try to give these concerns a context (specifically, mbox support). Ethan --20cf3071ce1472ccaa04c38ca8f2 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable It is pretty big and there are a couple places where the series could be si= mplified, the first patch in particular. I will break it out and resubmit p= iecewise but I'd like to know how to address these particular issues:
1. Are URIs the way to specify individual messages, despite bremner= 9;s concerns about too much of the API being strings? Is adding another lib= rary is the easiest way to parse URIs?

2. Is it OK to break maildir = relocatability, or is it worth it to pass more config to the library (perh= aps by adding it to the notmuch_database_t object)?

3. Is a global variable in the library acceptable? (I don't see an= y others.) If not, how to store mailstore state?

The patch series is= really more like a very rough draft to try to give these concerns a contex= t (specifically, mbox support).

Ethan

--20cf3071ce1472ccaa04c38ca8f2--