Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 192F8431FB6 for ; Tue, 4 Sep 2012 00:02:49 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id voSFIBznhSIn for ; Tue, 4 Sep 2012 00:02:48 -0700 (PDT) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4BE89431FAF for ; Tue, 4 Sep 2012 00:02:48 -0700 (PDT) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1T8n9l-0003xC-QO; Tue, 04 Sep 2012 08:02:44 +0100 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1T8n9l-0000qD-G7; Tue, 04 Sep 2012 08:02:41 +0100 From: Mark Walters To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH 0/6] emacs: customization for tag changes on archive In-Reply-To: References: User-Agent: Notmuch/0.14+30~g1894b09 (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Tue, 04 Sep 2012 08:02:40 +0100 Message-ID: <87ehmie0dr.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 93.97.24.31 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 3bdd87b49fc09967b268bb20b019e53c (of first 20000 bytes) X-SpamAssassin-Score: -1.8 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.8 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * 0.5 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2012 07:02:49 -0000 Hi The overall series looks good to me +1. I do like the slight tweak suggested by Michal in id:"xa1tipbvwdb0.fsf@mina86.com" (but don't feel strongly). Also, ideally there should be some tests, particularly for the multiple tag case as I imagine most people will just have a single tag so breakage would be unnoticed. However, neither of these should hold up the series. Finally: > An interesting by-product is that you can filter your mail into multiple > different inboxes, each with their own inbox tag, and (after you setup > `notmuch-archive-tags') you can read and archive each inbox separately > with built-in archiving functions. I am assuming that you are suggesting adding -inbox1 -inbox2 etc to notmuch-archive-tags? So the "unarchive" option will not work in this case? (This is *definitely* not a complaint: just a query in case I am missing something) Best wishes Mark > > BR, > Jani. > > > Jani Nikula (6): > emacs: add helper for tag change list manipulation > emacs: fix notmuch-message-replied-tags defcustom type > emacs: use new tag change helper to mark messages as replied > emacs: add support for custom tag changes on message/thread archive > emacs: add support for reversing notmuch-search-archive-thread tag > changes > emacs: add support for reversing notmuch-show-mark-read tag changes > > emacs/notmuch-lib.el | 14 ++++++++++++ > emacs/notmuch-message.el | 26 ++++++++++------------ > emacs/notmuch-show.el | 54 +++++++++++++++++++++++++++++++--------------- > emacs/notmuch-tag.el | 17 +++++++++++++++ > emacs/notmuch.el | 16 ++++++++++---- > 5 files changed, 91 insertions(+), 36 deletions(-) > > -- > 1.7.9.5 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch