Return-Path: <jrollins@finestructure.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 8A321431FAE
	for <notmuch@notmuchmail.org>; Mon,  2 Apr 2012 10:52:07 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.29
X-Spam-Level: 
X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id OEdfttYPbLKM for <notmuch@notmuchmail.org>;
	Mon,  2 Apr 2012 10:52:07 -0700 (PDT)
Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
	[131.215.239.19])
	by olra.theworths.org (Postfix) with ESMTP id EA03A431FBC
	for <notmuch@notmuchmail.org>; Mon,  2 Apr 2012 10:52:06 -0700 (PDT)
Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])
	by fire-doxen-postvirus (Postfix) with ESMTP id 7BA6D2E50D7B;
	Mon,  2 Apr 2012 10:52:04 -0700 (PDT)
X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new
Received: from finestructure.net (gwave-213.ligo.caltech.edu
 [131.215.114.213])	(Authenticated sender: jrollins)	by fire-doxen-submit
 (Postfix) with ESMTP id BA5362E50DD3;	Mon,  2 Apr 2012 10:51:58 -0700 (PDT)
Received: by finestructure.net (Postfix, from userid 1000)
	id 1898C89A; Mon,  2 Apr 2012 10:51:58 -0700 (PDT)
From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 6/8] cli: add support for batch tagging operations to
	"notmuch tag"
In-Reply-To:
 <f360a40bed50208d146aee8b06946b1b8315e818.1333231401.git.jani@nikula.org>
References: <cover.1333231401.git.jani@nikula.org>
	<f360a40bed50208d146aee8b06946b1b8315e818.1333231401.git.jani@nikula.org>
User-Agent: Notmuch/0.12+87~g3c4c85f (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Mon, 02 Apr 2012 10:51:55 -0700
Message-ID: <87wr5y3ttw.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2012 17:52:07 -0000

--=-=-=

On Sat, Mar 31 2012, Jani Nikula <jani@nikula.org> wrote:
> Add support for batch tagging operations through stdin to "notmuch
> tag". This can be enabled with the new --stdin command line option to
> "notmuch new". The input must consist of lines of the format:
>
> T +<tag>|-<tag> [...] [--] <search-terms>

Hey, Jani.  I can understand why you're going for this form, since it
mimics the command line arguments for tag and you want to be able to tag
for arbitrary searches, but I must say that I find it unappealing that
this functionality is *so* similar to that of notmuch restore, but the
file format is totally different.  Can't we unify all of this in a
better way?

This patch series seems to beg that we actually just unify the tag and
restore functions in to one thing.  They're really just doing the same
thing.  If we extended restore to accept a search-term instead of a
message id they would in fact be identical.

The more I think about it the more it makes sense to me that we just
merge tag and restore, and extend the input file format to be able to
accept search terms.  It just doesn't make sense to have these two
interfaces that do basically the exact same thing but in a slightly
divergent way.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPeec7AAoJEO00zqvie6q8oIEP/2UsIOwTOJXFf2TP6OBC3Iu2
t/JIL0wLUQHQgtV4JyFieSZrB9UdDRRxdFTd2vYbW4AJXVBDNBKF6841qliGnKGO
P0BbECbHcyXIphnMbKIHyXSWRZBvLp2zQImJ+D3qz/BMEjXSDI5rX8kiDSeqcTW+
DKyEE8Xo4ySN8R4+UK1ARKhJjkJIU9A1kxmqrx85cJRzXIfMTDeW2ej2GUzWaZVa
IgCr/uBQ7DLn1WqgaF73eU8l+dG+OUJXnrnGjQHRklZ0ci6M/gLNpT4biq/2bZpp
jp/bIsT7HGcMSYBTvXxEjU8zynGBwmcJBWTvX54Z7vphaj+XhR+BTez4Jot4d/EH
W+toJvEv40Hek5PHc++uyyGxbR4IRAZ4B90UiHAoiRyjcCKoThhHDf/BaGEgJgsS
2KcOoZE2t+3gsd8mcbaAs9v14T0OLo95jT8BKouLdGW7Z6gF/IcEMlm77PW2OBmv
5cu0nThQ/vxFzcoVIvQ5ueeV4rJhVXa7BUTTsxTAb2V3qX4jIjxhh166a45NLH+r
jJex0VEr06bLwL9hvZv/5rpZ6zu9BoufvOXON1gal168tZg5U3UCdo+iPSaf8MoB
uEYe5Tcdyv8OI8cogixVfQlQG1ewKBaf+WRz9fY/x5H9Id7DoRcvhv41lEYOqTPB
xY8zVEVVIiSeGOq6K+mF
=RF/P
-----END PGP SIGNATURE-----
--=-=-=--