Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A4698431FBC for ; Tue, 22 Dec 2009 22:57:28 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aW57Cb-qsH8v for ; Tue, 22 Dec 2009 22:57:28 -0800 (PST) Received: from office.neopsis.com (office.neopsis.com [78.46.209.98]) by olra.theworths.org (Postfix) with ESMTP id C3A06431FAE for ; Tue, 22 Dec 2009 22:57:27 -0800 (PST) Received: from calvin.caurea.org ([62.65.141.13]) (authenticated user tom@dbservice.com) by office.neopsis.com (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits)); Wed, 23 Dec 2009 07:57:21 +0100 Message-ID: <4B31BF51.9030508@dbservice.com> Date: Wed, 23 Dec 2009 07:57:21 +0100 From: Tomas Carnecky User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a1pre) Gecko/20091222 Lightning/1.1a1pre Shredder/3.1a1pre MIME-Version: 1.0 To: Olly Betts References: <1261450617-24616-1-git-send-email-tom@dbservice.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: notmuch@notmuchmail.org Subject: Re: [notmuch] [PATCH] Add post-add and post-tag hooks X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2009 06:57:28 -0000 On 12/23/09 12:02 AM, Olly Betts wrote: > Tomas Carnecky writes: >> #if defined(__sun__) >> ... sprintf, stat etc >> #else >> (void) path; >> return dirent->d_type == DT_DIR; >> #endif > > Rather than a platform-specific check, it would be better to check if DT_DIR > is defined. > > Beware that even on Linux (where the d_type field is present), it may always > contain DT_UNKNOWN for some filesystems, so you really should check for that > case and fall back to using stat() instead. Currently configure is a simple shell script and not some autoconf magic. And I don't know how eager Carl is to use autoconf, scons, cmake or similar. tom