Message-ID: <4EF9D5E8.4050203@fifthhorseman.net>
Date: Tue, 27 Dec 2011 09:27:52 -0500
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111120 Icedove/8.0
MIME-Version: 1.0
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME
	traversal.
References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>
	<1323460468-4030-1-git-send-email-amdragon@mit.edu>
	<1323460468-4030-3-git-send-email-amdragon@mit.edu>
	<87k46572f7.fsf@gmail.com> <20111224034500.GA1927@mit.edu>
In-Reply-To: <20111224034500.GA1927@mit.edu>
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature";
	boundary="------------enig0CF343C17A4FA2E8E65344DD"
Precedence: list
Reply-To: notmuch <notmuch@notmuchmail.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig0CF343C17A4FA2E8E65344DD
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 12/23/2011 10:45 PM, Austin Clements wrote:
> Quoth Dmitry Kurochkin on Dec 10 at  3:25 am:
>> +           /* For some reason the GMimeSignatureValidity returned
>> +            * here is not a const (inconsistent with that
>> +            * returned by
>> +            * g_mime_multipart_encrypted_get_signature_validity,
>> +            * and therefore needs to be properly disposed of.
>> +            * Hopefully the API will become more consistent. */
>>
>> Ouch.  In gmime 2.6 this API has changed, but looks like the
>> issue is still there.  Is there a bug for it?  If yes, we should
>> add a reference to the comment.  Otherwise, we should file the
>> bug and then add a reference to the comment :)
>=20
> It looks like they're both non-const in 2.6 (which makes more sense to
> me).  I updated the comment to mention this.

Here's the bug report where this was discussed with upstream, fwiw:

  https://bugzilla.gnome.org/show_bug.cgi?id=3D640911

	--dkg


--------------enig0CF343C17A4FA2E8E65344DD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQJ8BAEBCgBmBQJO+dXoXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwRUU1QkU5NzkyODJEODBCOUY3NTQwRjFD
Q0QyRUQ5NEQyMTczOUU5AAoJEMzS7ZTSFznpEJUQAKkrIZvaQujPSzboPkibd01o
sYNVyHfZ7k9/oHMqfb+lV5yNG2wdG7zPP8TKMnPVMOd915Exy4WImeEtShgRogV7
sp/JFTX84qDfJ78kPPEp74gk2i8vu7BhRte54abxCOs+HAj+cnmE7mgxl1o/Scpe
hVFLuTbbpOELNuoWDmG58Whci8mV2rLhaMl4og86IJgxxEMpwCd1b8KpBV1QnYvV
fWBjuISxU24CiPCF3+rKIFPGuLiWzbE1fmclkhHwq2rGuHzmGrqfqUStUMX65WlR
Rjl7+QwPnAlhkRJF4jpG8ZFPXM48ZXWcuhK5zCi3Mf0FG7toa9JFHe5viK/K+ZhD
FDP0Ju/vTNG9WUNK04b3xZsuIIjJrwY0oxQmPso/dci2o4alDhwNMci72EYB1tYC
N8ToYfU3Hy1GkHZHWzOv+7kQakcQhrGEkAIK9y7tNsc/STaxdOWmeBHYep0UYXXw
QyS/MB7GxB8lNye+nbvXaMzi/3wU86rm3RZTACuPsNPs1bBz0Y1FVwzs8Vrma9ad
gv8x5kf8LhOoSDn/GTtrqfxyrzveDHT1PzfOJbo2BjAv5OqDfUf+d95WWdKWNKmF
3vxEVZMa6qOz67pcD7XjftwSkzkctXRrpUWeuDwmh3ICmVR4rjbiOMBD7KOSzigl
RV/4dL48Mj7weT/YOdRP
=bIIL
-----END PGP SIGNATURE-----

--------------enig0CF343C17A4FA2E8E65344DD--