Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1F2B4421176 for ; Sun, 29 Jan 2012 23:21:31 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7cQOSyOc7sHZ for ; Sun, 29 Jan 2012 23:21:30 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7C73B431FBC for ; Sun, 29 Jan 2012 23:21:30 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so3674972wgb.2 for ; Sun, 29 Jan 2012 23:21:29 -0800 (PST) Received: by 10.180.78.233 with SMTP id e9mr24738256wix.0.1327908089404; Sun, 29 Jan 2012 23:21:29 -0800 (PST) Received: from localhost ([109.131.39.11]) by mx.google.com with ESMTPS id q7sm28126018wix.5.2012.01.29.23.21.28 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 29 Jan 2012 23:21:28 -0800 (PST) From: Pieter Praet To: Dmitry Kurochkin , David Edmondson Subject: Re: [RFC] Re: [PATCH] emacs: Add `notmuch-show-stash-gmane' and `notmuch-show-stash-gmane-and-go'. In-Reply-To: <87zkd9je5j.fsf@gmail.com> References: <87pqe6vcgv.fsf@praet.org> <1327583610-30085-1-git-send-email-pieter@praet.org> <878vkt35ao.fsf@praet.org> <87zkd9je5j.fsf@gmail.com> User-Agent: Notmuch/0.11+132~ga81001f (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Mon, 30 Jan 2012 08:19:34 +0100 Message-ID: <87sjix64jd.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2012 07:21:31 -0000 On Fri, 27 Jan 2012 20:36:40 +0400, Dmitry Kurochkin wrote: > On Fri, 27 Jan 2012 09:42:23 +0100, Pieter Praet wrote: > > On Thu, 26 Jan 2012 14:40:26 +0000, David Edmondson wrote: > > > In general, I like this. > > > > > > - I think that the stash function(s) should take an optional argument > > > specifying the archive to use. That will make testing simpler and also > > > allow people to produce preferred bindings more easily. > > > > > > > Agreed. In fact, apparently that last patch [1] of mine made the test > > suite hang @ emacs:"Stashing in notmuch-show" due to it waiting for > > `completing-read' to finish... Sorry for that. > > > > > - "Message archive: " feels better than "ML Archive: ", but I don't > > > really care. > > > > > > > Agreed. > > > > FWIW I believe "Mailing list archive" would be better. > Agreed. > Regards, > Dmitry > > > > - Don't base the patch on the thing that I posted, just on master from > > > the repository - no need to make David's life harder. > > > > Seeing as how it was only a minor improvement to your idea (and further > > discussion/correction was probably appropriate), I intended for you to > > squash it into your original patch. > > > > Anyways, patch (relative to master) follows... > > > > > > Peace > > > > -- > > Pieter > > > > [1] id:"1327583610-30085-1-git-send-email-pieter@praet.org" > > _______________________________________________ > > notmuch mailing list > > notmuch@notmuchmail.org > > http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter