Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 49556431FD6
	for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 09:39:14 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id QmrPOGly12qK for <notmuch@notmuchmail.org>;
	Sun, 30 Jun 2013 09:39:08 -0700 (PDT)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 25512431FCB
	for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 09:39:08 -0700 (PDT)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1UtKeZ-0003Mc-KU; Sun, 30 Jun 2013 13:39:07 -0300
Received: (nullmailer pid 15568 invoked by uid 1000); Sun, 30 Jun 2013
	16:39:04 -0000
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 3/3] contrib: pick: fix refresh result
In-Reply-To: <1372582512-10777-4-git-send-email-markwalters1009@gmail.com>
References: <1372582512-10777-1-git-send-email-markwalters1009@gmail.com>
	<1372582512-10777-4-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.15.2+193~gb7df509 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 30 Jun 2013 13:39:03 -0300
Message-ID: <87ip0vtuxk.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Jun 2013 16:39:14 -0000

Mark Walters <markwalters1009@gmail.com> writes:

> The function notmuch-pick-refresh-result (used to update tag changes)
> was not quite correct: sometimes it got the choice between the subject
> and " ..." wrong. This was always true but the new code often calls
> this (when opening a message in the message pane to remove the unread
> tag) while the async pick process is still running and this caused
> mistakes which made the tests fail.

This looks OK, and independant of the other patches.

removing "needs-review".

d