Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B9DA86DE1352 for ; Tue, 28 Jul 2015 12:42:57 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.157 X-Spam-Level: X-Spam-Status: No, score=0.157 tagged_above=-999 required=5 tests=[AWL=0.157] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hH1-9dPRzq-x for ; Tue, 28 Jul 2015 12:42:56 -0700 (PDT) Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) by arlo.cworth.org (Postfix) with ESMTPS id F29076DE0B20 for ; Tue, 28 Jul 2015 12:42:55 -0700 (PDT) Received: from remotemail by gitolite.debian.net with local (Exim 4.80) (envelope-from ) id 1ZKAlC-0006rB-8n; Tue, 28 Jul 2015 19:41:58 +0000 Received: (nullmailer pid 10660 invoked by uid 1000); Tue, 28 Jul 2015 19:41:43 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] build: add "set -e" to version script generation In-Reply-To: References: <1438022552-24342-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 28 Jul 2015 21:41:43 +0200 Message-ID: <87d1zcul1k.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2015 19:42:57 -0000 Tomi Ollila writes: > On Mon, Jul 27 2015, David Bremner wrote: > >> It turns out that on certain systems like FreeBSD, c++filt is not >> installed by default. It's basically OK if we fail the build in that >> case, but what's really not OK is for the build to continue and >> generate bad binaries. >> --- >> lib/gen-version-script.sh | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh >> index 64a7374..aa1ca43 100644 >> --- a/lib/gen-version-script.sh >> +++ b/lib/gen-version-script.sh >> @@ -1,3 +1,4 @@ >> +set -e > > LGTM, although I'd prefer 'set -eu' (both visual observation and testing > with set -eux worked for me). > OK, pushed with set -eu. d