DomainKey-Signature: a=rsa-sha1; c=nofws; d=sspaeth.de; h=from:to:cc:subject
	:in-reply-to:references:date:message-id:mime-version:
	content-type; q=dns; s=sspaeth.de; b=UJWKr0uRzTFSZJlRsBOoX0/7ozv
	a/P2WtVNEv/Evq/NEXeTpGf2g9OUqv2z5zm0d4s5V3APRDPODg+9mxA9ExEdVgl6
	buu7DiFmI2WBdUeHE940YGTUeQvL3vU/QtyLOJpHalWdvNy9PGTYjM1VN4cZHQ65
	C+6e/9OkTBNR/2tI=
From: Sebastian Spaeth <Sebastian@sspaeth.de>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues
In-Reply-To: <20110929150147.GC17905@mit.edu>
References: <87ei34rnc5.fsf@yoom.home.cworth.org>
	<1307822683-848-1-git-send-email-amdragon@mit.edu>
	<87fwjgoc8f.fsf@SSpaeth.de> <20110929150147.GC17905@mit.edu>
User-Agent: Notmuch/0.7-19-gee4579a (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Fri, 30 Sep 2011 11:21:38 +0200
Message-ID: <87ehyy4c7x.fsf@SSpaeth.de>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=

On Thu, 29 Sep 2011 11:01:47 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Sebastian Spaeth on Sep 28 at  6:36 pm:
> > db.find_message_by_filename("moo")
> > Internal error: Failure to ensure database is writable
> > (lib/directory.cc:100).

> It appears that looking up a directory requires a writable database
> because notmuch will try to *create* a database document for the
> directory if one doesn't already exist.  This is clearly wrong
> behavior for a "find" function.

First of all, I consider libnotmuch exiting, taking python down, an
outright bug. So we should modify this case to return:
NOTMUCH_STATUS_READ_ONLY_DATABASE

so I can at least give some sensible error than having an angry mob run
with pitchforks towards me.

Ideally, we don't need READ-WRITE dbs for the find :-)

As it is, the same issue happens with the
notmuch_database_get_directory call, which should be protected in the
same manner (and probably has the same root cause). It is debatable
whether get_directory should be creating a directory on demand, I guess,
but it should never crash.

I have documented this in the python bindings, so it's not super urgent.
But it's dangerous and wrong nonetheless.

Sebastian

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6FiiMACgkQVYX1jMgnoGJMxgCfXCYv8R6R0hW39hXgCimR/nu8
kVQAn0IdI1qr4ZT/tOHaksiQ/36WmH+N
=kYfn
-----END PGP SIGNATURE-----
--=-=-=--