Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AA85A4196F6 for ; Fri, 29 Jan 2010 06:55:32 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.428 X-Spam-Level: X-Spam-Status: No, score=-0.428 tagged_above=-999 required=5 tests=[AWL=-0.429, BAYES_50=0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id azdTky8wUx9j for ; Fri, 29 Jan 2010 06:55:32 -0800 (PST) Received: from batman.acm.jhu.edu (batman.acm.jhu.edu [128.220.251.35]) by olra.theworths.org (Postfix) with ESMTP id 1ACDE431FDA for ; Fri, 29 Jan 2010 06:55:32 -0800 (PST) Received: from batman.acm.jhu.edu (localhost.localdomain [127.0.0.1]) by batman.acm.jhu.edu (Postfix) with ESMTP id 0C257CED64; Fri, 29 Jan 2010 09:55:30 -0500 (EST) Received: by batman.acm.jhu.edu (Postfix, from userid 99) id 00F89CEE89; Fri, 29 Jan 2010 09:55:30 -0500 (EST) Received: from lucky (c-69-255-36-229.hsd1.md.comcast.net [69.255.36.229]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by batman.acm.jhu.edu (Postfix) with ESMTPSA id 2F03FCED64; Fri, 29 Jan 2010 09:55:26 -0500 (EST) Received: by lucky (Postfix, from userid 1000) id 212333341A3; Fri, 29 Jan 2010 09:54:34 -0500 (EST) From: Jesse Rosenthal To: Sebastian Spaeth , Jameson Rollins , notmuch@notmuchmail.org In-Reply-To: <87ockdoxl7.fsf@SSpaeth.de> References: <873a1zs3t5.fsf@jhu.edu> <878wbj4nfq.fsf@servo.finestructure.net> <87ockdoxl7.fsf@SSpaeth.de> Date: Fri, 29 Jan 2010 09:54:33 -0500 Message-ID: <87mxzxyn9y.fsf@jhu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [notmuch] Fcc, Maildir, and Emacs message-mode -- a bit of code X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2010 14:55:32 -0000 On Fri, 29 Jan 2010 14:21:56 +0100, Sebastian Spaeth wrote: > First, I think this FCC method is phantastic and it works like a > charm. I agree that we should include the snippets at least in some > "contrib" directory (or doc/examples) to make it easier to find. I'm glad it's proved useful. However, I should say that I'd be wary of distributing it, or even recommending it, without at least rudimentary error checking -- even if it's just the delivery function returning either 0 or -1, and the emacs wrapper reporting failure back to the user in a sensible fashion. As it is now, a failed delivery will either go silently by, or muck everything up in a not-so-useful way. Returning some sort of success/fail would just take a couple of try/except lines. I would have put that in myself, but I just whipped it up for personal use (and then never used it). Best, Jesse