Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CEC05429E25 for ; Mon, 27 Jun 2011 14:44:32 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KbPlmjbR5FWZ for ; Mon, 27 Jun 2011 14:44:32 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 5AC83431FD0 for ; Mon, 27 Jun 2011 14:44:32 -0700 (PDT) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 990DE66E01A3; Mon, 27 Jun 2011 14:44:30 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from servo.finestructure.net (gwave-169.ligo.caltech.edu [131.215.114.169]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id A3D4966E0130; Mon, 27 Jun 2011 14:44:26 -0700 (PDT) Received: by servo.finestructure.net (Postfix, from userid 1000) id E077DB8; Mon, 27 Jun 2011 14:44:27 -0700 (PDT) From: Jameson Graef Rollins To: Austin Clements Subject: Re: [PATCH] Do not attept to output part raw if part is not GMimePart. In-Reply-To: References: <1307032735-27427-1-git-send-email-jrollins@finestructure.net> <1307120466-4980-1-git-send-email-jrollins@finestructure.net> <87wrgccedd.fsf@yoom.home.cworth.org> <87mxh319un.fsf@servo.factory.finestructure.net> User-Agent: Notmuch/0.5-292-gaa2fa19 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 27 Jun 2011 14:44:25 -0700 Message-ID: <878vsn0x1i.fsf@servo.factory.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2011 21:44:33 -0000 --=-=-= On Mon, 27 Jun 2011 16:43:36 -0400, Austin Clements wrote: > Just to clarify my understanding, --format=raw is only intended to > work on either the whole message (special-cased in do_show_single) or > a leaf MIME part, and in any other case, it will output nothing? The > raw output test cases seem pretty thin. Hey, Austin. The raw part output works for *any* part, be it leaf part, multipart, message/rfc822, etc. I added a bunch of tests for raw part output that should cover all of this, although I don't think they've been pulled into master yet. I think there are a lot of open questions about what should be output for multipart raw. We should output _something_, though. I think we can fix all of this up for 0.7, based on the work you've already done, after 0.6 is released. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOCPm5AAoJEO00zqvie6q8Mo8QAKUMpBtue4zLuFEbKvLjbZsO FbjK9upScbs4yau/cI5NjvWDOcZ93VtKmbfS72FTCebaFefb1u1xEbf0RjBrg4wP nqTlaTIDJ24Xq1tnSVRY0gdY5512bK/tVFSZiS/RRLJCN7GxRAqat8ASqpFrMUPv hPGWUg9JvifAelLV9ADcXDDvZ/PMw7zVnED0dPUqweci8Ek2yZDptnRAyOSut4MO E+Mzr12DjWWDQD6ZcYvCXur9ho+BmO55G3nxaZAZ/E5rf/RDDVQrKpKMS5IoKn6D baJjfIezBfsT9xciL/riyfhuSOBIr8HkvsshvyNbRpYhs4HMTXqlzRVQwqBzTMK0 ql5EYL5gPVfWAE+Z9aJj1j6AtyqmMFGXYWSCy8Nuvmw/E3XdrSmoblThwGdlyKkc ca5qcfHABvHlf//RW5+ElpmuXaW3vCGBpCDd0lsF4a2lpn94//6c94t/Y9NGUhmq zRvmkyJ+mw0FN9iYEAs4Rc8W6uaA2gYeb+RmEiPYfV7ovegkdm092elYTRT4BrBz ZHDYPjHiaze7XJnjkvz/ENasazi9vMLoYfuxqzjBr6PM1+UnTXMO6Pl8C5IE+423 rGonHJ50fnOjvnpmuRz2psHfbLKUxr92JrpmDMabaDxV0oi4O41O+itRbuRLOWWb figKUQH/9Gh4blxY3Lxh =WoK+ -----END PGP SIGNATURE----- --=-=-=--