Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7F4DE431FB6 for ; Tue, 19 Apr 2011 07:46:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7WwmsSYC8YUf for ; Tue, 19 Apr 2011 07:46:37 -0700 (PDT) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A6899431FB5 for ; Tue, 19 Apr 2011 07:46:37 -0700 (PDT) Received: by wwi36 with SMTP id 36so6278897wwi.2 for ; Tue, 19 Apr 2011 07:46:35 -0700 (PDT) Received: by 10.227.1.102 with SMTP id 38mr6318080wbe.109.1303224395296; Tue, 19 Apr 2011 07:46:35 -0700 (PDT) Received: from localhost (29.56-240-81.adsl-dyn.isp.belgacom.be [81.240.56.29]) by mx.google.com with ESMTPS id o23sm3936435wbc.61.2011.04.19.07.46.33 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2011 07:46:34 -0700 (PDT) From: Pieter Praet To: Jameson Rollins , notmuch@notmuchmail.org Subject: Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces In-Reply-To: <874o6pm8vx.fsf@servo.finestructure.net> References: <1301202992-25444-1-git-send-email-jrollins@finestructure.net> <874o6pm8vx.fsf@servo.finestructure.net> User-Agent: Notmuch/0.5-87-g30203d7 (http://notmuchmail.org) Emacs/23.1.50.1 (x86_64-pc-linux-gnu) Date: Tue, 19 Apr 2011 16:46:32 +0200 Message-ID: <87y6365mev.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2011 14:46:40 -0000 On Sat, 26 Mar 2011 22:26:26 -0700, Jameson Rollins wrote: > On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins wrote: > > This enables the proper face customization UI for > > notmuch-search-line-faces. > > Hey, folks. amdragon was the one who figured out that custom-face-edit > was the correct value-type to use to get the face customization ui for > the notmuch-search-line-faces list. However, he seems to think this > might not be the right solution. Austin: care to comment? > > jamie. Non-text part: application/pgp-signature > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch No idea why it wouldn't be a good solution, only "negative" thing I could find was a comment "FIXIT: Use a better equivalent to custom-face-edit if there is one" in diredful.el:312 [1] FWIW, in Org-mode (org-todo-keyword-faces @ org-faces.el:355-371 [2], exactly the same use case) they do it like this: :type '(repeat (cons (string :tag "Keyword") (choice :tag "Face " (string :tag "Color") (sexp :tag "Face"))))) [1] http://www.emacswiki.org/emacs-en/diredful.el [2] http://orgmode.org/w/?p=org-mode.git;a=blob;f=lisp/org-faces.el;h=7bb3055c7d707b069ee826dfff54b8e441566e3e;hb=HEAD