Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 6DEB86DE19C7 for ; Sat, 17 Oct 2015 07:24:35 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.753 X-Spam-Level: X-Spam-Status: No, score=0.753 tagged_above=-999 required=5 tests=[AWL=0.101, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kayMXz6O-F-V for ; Sat, 17 Oct 2015 07:24:33 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 3E0C76DE02DD for ; Sat, 17 Oct 2015 07:24:33 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 6E41B1000CA; Sat, 17 Oct 2015 17:24:42 +0300 (EEST) From: Tomi Ollila To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH 4/4] NEWS: news for notmuch_directory_delete In-Reply-To: <1445087213-21364-4-git-send-email-jani@nikula.org> References: <1445087213-21364-1-git-send-email-jani@nikula.org> <1445087213-21364-4-git-send-email-jani@nikula.org> User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2015 14:24:35 -0000 On Sat, Oct 17 2015, Jani Nikula wrote: > --- > NEWS | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/NEWS b/NEWS > index 9940f8185e82..c5417144b755 100644 > --- a/NEWS > +++ b/NEWS > @@ -47,6 +47,19 @@ Library > The use of absolute paths is now enforced when calling > `notmuch_database_{open, create}`. > > +New function `notmuch_directory_delete` to delete directory documents > + > + Previously there was no way to delete directory documents from the > + database, leading to confusing results when the "ghost" directory > + document of a renamed or deleted filesystem directory was > + encountered every time the parent directory was being scanned by > + `notmuch new`. The mtime of the old directory document was also used > + if a directory by the same name was added again in the filesystem, > + potentially bypassing the scan for the directory. The issues are > + fixed by providing a library call to delete directory documents, and > + deleting the old documents in `notmuch new` on filesystem directory > + removal or rename. LGTM (format). > + > nmbug-status > ------------ > > -- > 2.1.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch