Date: Thu, 19 Jan 2012 15:28:39 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions
Message-ID: <20120119202839.GQ16740@mit.edu>
References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
	<1327000744-25463-1-git-send-email-pieter@praet.org>
	<20120119193647.GN16740@mit.edu> <87pqef4fuk.fsf@qmul.ac.uk>
	<m24nvr4fdc.fsf@wal122.wireless-pennnet.upenn.edu>
	<87zkdjmofb.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87zkdjmofb.fsf@qmul.ac.uk>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Notmuch Mail <notmuch@notmuchmail.org>, Pieter Praet <pieter@praet.org>,
	Aaron Ecay <ecay@sas.upenn.edu>
Precedence: list

Quoth Mark Walters on Jan 19 at  8:23 pm:
> 
> > On Thu, 19 Jan 2012 20:06:27 +0000, markwalters1009@gmail.com wrote:
> > > I would actually like make a different suggestion: extend
> > > auto_exclude_tags to notmuch-show as well. I was quite surprised to see
> > > my deleted (ie hidden rather than actually deleted) messages return when
> > > viewing a thread.
> > 
> > It might be best to show the messages in the thread – after all, you
> > might want to “undelete” (or “unspam”) those messages in light of later
> > replies to them.  (And if you are sure you really want them gone, you
> > should be deleting them or moving them out of your maildir periodically,
> > rather than relying on notmuch to not show them to you ever.)
> 
> I am happy with them appearing as a non matching message, but currently
> they appear as a full open message. (The patch to achieve this is
> trivial: essentially transpose part of Austin's patch of
> notmuch-search.c into notmuch-show.c)

This definitely sounds like the right thing to do.  We can argue about
more sophisticated UIs, but it should do this at a minimum.